shouldSkipRequest should give reason for skipping request instead of boolean #1186
Comments
5 tasks
cmwylie19
added a commit
that referenced
this issue
Oct 2, 2024
…nstead of boolean (#1208) ## Description PR to make shouldSkipRequest function more like filterNoMatchReason. Relates to #1186 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed --------- Co-authored-by: Case Wylie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
shouldSkipRequestshould give reason for skipping request instead of boolean. FilterMatchNoReason ouputs in the log why the filter denied process the callback, enhances UX and DX to know which filter is preventing your callback from being called.Describe the solution you'd like
Give reason why request is being skipped like in
filterMatchNoReasonDescribe alternatives you've considered
(optional) A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: