Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support for machine learning force field in OpenMM DMFF plugin #152

Open
tucy22 opened this issue Nov 30, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@tucy22
Copy link

tucy22 commented Nov 30, 2023

Summary

Provide support for machine learning (ML) force field in OpenMM DMFF plugin. Present version does not yet support well, such as EANN and SGNN models.

Motivation

The OpenMM DMFF plugin uses save_dmff2tf.py script to transform a JAX model trained in DMFF to a tensorflow model used for OpenMM simulations. In this module, both classical and ADMP force field are considered. While the usage of ML force field in ther transformation is not clear. If ML force field are defined in XML file (referenced as https://github.com/deepmodeling/DMFF/blob/master/docs/user_guide/4.4MLForce.md), there will occur errors in running save_dmff2tf.py script (detailed error message can be browsed in Further Information part). The used ML models are EANN and SGNN.

Suggested Solutions

  1. Revise the potential generation function when using ML, and consider the situation of using ADMP and ML simultaneously.
  2. Provide a specific instruction for the usage of ML forces in OpenMM DMFF Plugin docs.

Further Information, Files, and Links

reportbug.zip
test.zip
Above files record two different errors when using ML in this plugin.

@tucy22 tucy22 added the enhancement New feature or request label Nov 30, 2023
@dingye18
Copy link
Contributor

Fixed in PR #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants