Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new helper functions #329

Merged
merged 2 commits into from
Mar 28, 2022
Merged

add new helper functions #329

merged 2 commits into from
Mar 28, 2022

Conversation

ukane-philemon
Copy link
Contributor

This diiff adds new helper funcs validateTicketHash() and getCommitmentAddress(). Also it modifies helper func validateSignature(). Originally part of #322

jholdstock
jholdstock requested changes Mar 17, 2022
View reviewed changes
Copy link
Member

@jholdstock jholdstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few comments here. I think that addressing these comments will result in some significant changes to the PR, so to avoid wasting time I won't review in more detail until they are sorted.

webapi/helpers.go Outdated Show resolved Hide resolved
webapi/helpers.go Outdated Show resolved Hide resolved
webapi/helpers.go Outdated Show resolved Hide resolved
webapi/helpers.go Outdated Show resolved Hide resolved
webapi/middleware.go Outdated Show resolved Hide resolved
webapi/middleware.go Show resolved Hide resolved
@ukane-philemon
Copy link
Contributor Author

@jholdstock thanks for the review, changes have been applied.

@jholdstock
Copy link
Member

Going to merge this with a couple of minor outstanding issues. I will fix those myself in a follow-up PR shortly.

@jholdstock jholdstock merged commit 4d4f9c8 into decred:master Mar 28, 2022
@jholdstock jholdstock mentioned this pull request Mar 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jholdstock jholdstock Awaiting requested review from jholdstock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ukane-philemon @jholdstock