app: Fix amounts displayed for token transactions in tx history #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When displaying token transactions on the wallet page for the parent asset, the unit info for the parent asset was being used, causing incorrect amounts.
JoeGruffins
approved these changes
Sep 30, 2024
dev-warrior777
approved these changes
Sep 30, 2024
buck54321
requested changes
Oct 6, 2024
| let amtAssetID = assetID | ||
| let feesAssetID = assetID | ||
| if (tx.tokenID) { | ||
| amtAssetID = tx.tokenID |
There was a problem hiding this comment.
Won't amtAssetID already be assetID?
| let feesAssetID = assetID | ||
| if (tx.tokenID) { | ||
| amtAssetID = tx.tokenID | ||
| if (assetID !== tx.tokenID) feesAssetID = assetID |
There was a problem hiding this comment.
In what case would assetID no be tx.tokenID for a token tx?
| } | ||
|
|
||
| const amt = Doc.formatCoinValue(tx.amount, app().unitInfo(assetID)) | ||
| const amtUnit = app().assets[assetID].symbol.split('.')[0].toUpperCase() |
There was a problem hiding this comment.
I know this was wrong before, but we should be getting the ticker for an asset from its UnitInfo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When displaying token transactions on the wallet page for the parent asset, the unit info for the parent asset was being used, causing incorrect amounts.
Closes #2994