-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
local memory storage publicURL and filename mismatch #66
Comments
I forked the repos to take a stab at it. On the surface it seems like I could simply replace /local_asset/ with /assets/ as the |
Oh, hey. The generated Now that I'm writing this out, though, it seems pretty silly. A better approach would be to have the memory storage just generate asset URLs that link to the asset on the content service directly.
It's not quite that simple but it's close! The assets are served from the content service but the page content is served from the presenter, so the asset URL can't just be a relative one. You'll need to add a |
Ah, thanks for the additional context Ash. There are several options then. In addition to proxying /local_assets/ to http://content-service:9000/assets/ from nexus-control |
Haha, yep, that'll just give you CDN URLs 😉 |
I'm going to put this in as an issue based on our email thread and what I think might be happening.
We have a content service running with in-memory storage rather than remote cloud files storage.
A call to
GET /assets
returns a dictionary of items such as...The problem is
GET /__local_asset__/filename_random_string.ext
is not found and returns a ResourceNotFound error.It looks like in
src/storage/memory.js
assetURLPrefix is prepended to form the publicURL.A request to
GET /assets/filename_random_string.ext
does return the expected asset.The text was updated successfully, but these errors were encountered: