Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vm): Add Events about power state changes #562

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat(vm): Add Events about power state changes #562

wants to merge 8 commits into from

Conversation

diafour
Copy link
Member

@diafour diafour commented Dec 9, 2024

Description

  • Implement EventRecorderLogger to record Event and write it log.

Why do we need it, and what problem does it solve?

We need meaningful Events for powerstate changes.

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@diafour
feat(vm): Add Events about power state changes
14fbad4 
- Also duplicate these events in log.

Signed-off-by: Ivan Mikheykin <[email protected]>
@diafour
++
b2b00ba 
Signed-off-by: Ivan Mikheykin <[email protected]>
@diafour diafour force-pushed the feat/vm/add_powerstate_events branch from d493620 to b2b00ba Compare December 10, 2024 07:50
@diafour diafour marked this pull request as ready for review December 11, 2024 09:35
@diafour
++ cleanup, add helper for stop event as an example
73ebdaf 
Signed-off-by: Ivan Mikheykin <[email protected]>
@diafour
++ cleanup, add helper for stop event as an example, rename reasons l…
e91bea9 
…ike stop->stopped

- Record VM powerstate Events from vmop controller.

Signed-off-by: Ivan Mikheykin <[email protected]>
@diafour
++ uncomment temporarily comments
2db4175 
Signed-off-by: Ivan Mikheykin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eofff eofff Awaiting requested review from eofff

@Isteb4k Isteb4k Awaiting requested review from Isteb4k

@yaroslavborbat yaroslavborbat Awaiting requested review from yaroslavborbat

@LopatinDmitr LopatinDmitr Awaiting requested review from LopatinDmitr

At least 1 approving review is required to merge this pull request.

Assignees

@diafour diafour

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@diafour