chore(ci): resolve comments

Signed-off-by: Nikita Korolev <[email protected]>
deckhouse · Jun 19, 2024 · 14cfa1b · 14cfa1b
1 parent c86d656
commit 14cfa1b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/.github/workflows/ dev_build_precache.yml → .github/workflows/dev_build_precache.yml b/.github/workflows/ dev_build_precache.yml → .github/workflows/dev_build_precache.yml
diff --git a/.github/workflows/dev_module_build-on-self-hosted-runner.yml b/.github/workflows/dev_module_build-on-self-hosted-runner.yml
@@ -46,7 +46,7 @@ jobs:
           if [[ "${{ github.ref_name }}" == 'pre-alpha' || "${{ github.ref_name }}" == 'main' ]]; then
             MODULES_MODULE_TAG="${{ github.ref_name }}"
           else
-            MODULES_MODULE_TAG="$(echo pr${{ github.event.pull_request.number }})"
+            MODULES_MODULE_TAG="pr${{ github.event.pull_request.number }}"
           fi
 
           echo "MODULES_MODULE_TAG=$MODULES_MODULE_TAG" >> "$GITHUB_OUTPUT"
@@ -104,7 +104,9 @@ jobs:
   lint_go:
     name: Run go linter
     if: needs.check_label.outputs.should_run
-    needs: set_vars
+    needs:
+      - check_label 
+      - set_vars
     runs-on: [self-hosted, ci-testing]
     steps:
       - name: Set up Go 1.21
@@ -127,7 +129,9 @@ jobs:
   lint_yaml:
     name: Run yaml linter
     if: needs.check_label.outputs.should_run
-    needs: set_vars
+    needs:
+      - check_label 
+      - set_vars
     runs-on: [self-hosted, ci-testing]
     steps:
       - name: Install Task
@@ -145,7 +149,9 @@ jobs:
   test:
     name: Run unit test
     if: needs.check_label.outputs.should_run
-    needs: set_vars
+    needs:
+      - check_label 
+      - set_vars
     runs-on: [self-hosted, ci-testing]
     steps:
       - name: Set up Go 1.21
@@ -172,7 +178,9 @@ jobs:
   dev_setup_build:
     name: Build and Push images
     if: needs.check_label.outputs.should_run
-    needs: set_vars
+    needs:
+      - check_label 
+      - set_vars
     runs-on: [self-hosted, ci-testing]
     env:
       MODULES_MODULE_TAG: ${{needs.set_vars.outputs.modules_module_tag}}

diff --git a/.github/workflows/dev_module_build.yml b/.github/workflows/dev_module_build.yml
@@ -38,7 +38,7 @@ jobs:
           if [[ "${{ github.ref_name }}" == 'pre-alpha' || "${{ github.ref_name }}" == 'main' ]]; then
             MODULES_MODULE_TAG="${{ github.ref_name }}"
           else
-            MODULES_MODULE_TAG="$(echo pr${{ github.event.pull_request.number }})"
+            MODULES_MODULE_TAG="pr${{ github.event.pull_request.number }}"
           fi
 
           echo "MODULES_MODULE_TAG=$MODULES_MODULE_TAG" >> "$GITHUB_OUTPUT"