From 0866b53ba876b158ce46c8181a8daa10aa79bb87 Mon Sep 17 00:00:00 2001 From: Adam Gall Date: Wed, 21 Feb 2024 15:06:03 -0500 Subject: [PATCH 1/6] Remove netlify actions, which haven't ran ever / in a long time. --- .github/workflows/release-netlify-dev.yaml | 27 ------------------- .github/workflows/release-netlify-prod.yaml | 26 ------------------ .../workflows/release-netlify-staging.yaml | 25 ----------------- 3 files changed, 78 deletions(-) delete mode 100644 .github/workflows/release-netlify-dev.yaml delete mode 100644 .github/workflows/release-netlify-prod.yaml delete mode 100644 .github/workflows/release-netlify-staging.yaml diff --git a/.github/workflows/release-netlify-dev.yaml b/.github/workflows/release-netlify-dev.yaml deleted file mode 100644 index fe24ca9b52..0000000000 --- a/.github/workflows/release-netlify-dev.yaml +++ /dev/null @@ -1,27 +0,0 @@ -# Development release workflow, generally following the guide posted here -# https://github.com/marketplace/actions/netlify-deploy -name: 'Netlify Development Deploy' -on: - push: # release on any push to develop - branches: - - develop - -jobs: - deploy: - name: 'Deploy' - runs-on: ubuntu-latest - environment: dev - - steps: - - uses: actions/checkout@v1 - - uses: jsmrcaga/action-netlify-deploy@master - with: - NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }} # auth token, generated at https://app.netlify.com/user/applications#personal-access-tokens - NETLIFY_SITE_ID: 'ccad1ffe-d58e-4238-bbca-cc09315855cf' # development site Netlify id (not a private identifier) - NETLIFY_DEPLOY_TO_PROD: true - build_directory: './.next/' - env: - NEXT_PUBLIC_ALCHEMY_TESTING_API_KEY: ${{ secrets.NEXT_PUBLIC_ALCHEMY_TESTING_API_KEY }} - NEXT_PUBLIC_INFURA_API_KEY: ${{ secrets.NEXT_PUBLIC_INFURA_API_KEY }} - NEXT_PUBLIC_SITE_URL: ${{ secrets.NEXT_PUBLIC_SITE_URL }} - NEXT_PUBLIC_ALCHEMY_API_KEY: ${{ secrets.NEXT_PUBLIC_ALCHEMY_API_KEY }} \ No newline at end of file diff --git a/.github/workflows/release-netlify-prod.yaml b/.github/workflows/release-netlify-prod.yaml deleted file mode 100644 index a25b264353..0000000000 --- a/.github/workflows/release-netlify-prod.yaml +++ /dev/null @@ -1,26 +0,0 @@ -# Production release workflow, generally following the guide posted here -# https://github.com/marketplace/actions/netlify-deploy -name: 'Netlify Production Deploy' -on: - release: # release on *release* to main - types: ['published'] - branches: - - main - -jobs: - deploy: - name: 'Deploy' - runs-on: ubuntu-latest - environment: prod - - steps: - - uses: actions/checkout@v1 - - uses: jsmrcaga/action-netlify-deploy@master - with: - NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }} # auth token, generated at https://app.netlify.com/user/applications#personal-access-tokens - NETLIFY_SITE_ID: '85f89f29-dd69-4697-b78d-3aa31d6c4c90' # production site Netlify id (not a private identifier) - NETLIFY_DEPLOY_TO_PROD: true - NEXT_PUBLIC_ALCHEMY_TESTING_API_KEY: ${{ secrets.NEXT_PUBLIC_ALCHEMY_TESTING_API_KEY }} - NEXT_PUBLIC_INFURA_API_KEY: ${{ secrets.NEXT_PUBLIC_INFURA_API_KEY }} - NEXT_PUBLIC_ALCHEMY_API_KEY: ${{ secrets.NEXT_PUBLIC_ALCHEMY_API_KEY }} - NEXT_PUBLIC_SITE_URL: ${{ secrets.NEXT_PUBLIC_SITE_URL }} \ No newline at end of file diff --git a/.github/workflows/release-netlify-staging.yaml b/.github/workflows/release-netlify-staging.yaml deleted file mode 100644 index dfb76b447c..0000000000 --- a/.github/workflows/release-netlify-staging.yaml +++ /dev/null @@ -1,25 +0,0 @@ -# Staging release workflow, generally following the guide posted here -# https://github.com/marketplace/actions/netlify-deploy -name: 'Netlify Staging Deploy' -on: - push: # release on any push to staging - branches: - - staging - -jobs: - deploy: - name: 'Deploy' - runs-on: ubuntu-latest - environment: staging - - steps: - - uses: actions/checkout@v1 - - uses: jsmrcaga/action-netlify-deploy@master - with: - NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }} # auth token, generated at https://app.netlify.com/user/applications#personal-access-tokens - NETLIFY_SITE_ID: '93816111-a19e-4218-b9ce-c480fab074b4' # staging site Netlify id (not a private identifier) - NETLIFY_DEPLOY_TO_PROD: true - NEXT_PUBLIC_ALCHEMY_TESTING_API_KEY: ${{ secrets.NEXT_PUBLIC_ALCHEMY_TESTING_API_KEY }} - NEXT_PUBLIC_INFURA_API_KEY: ${{ secrets.NEXT_PUBLIC_INFURA_API_KEY }} - NEXT_PUBLIC_ALCHEMY_API_KEY: ${{ secrets.NEXT_PUBLIC_ALCHEMY_API_KEY }} - NEXT_PUBLIC_SITE_URL: ${{ secrets.NEXT_PUBLIC_SITE_URL }} \ No newline at end of file From 9d1a119aa2ae93bcb938f5d497f0663ac37a65f4 Mon Sep 17 00:00:00 2001 From: Adam Gall Date: Wed, 21 Feb 2024 15:06:28 -0500 Subject: [PATCH 2/6] Remove reference to Notion in PR template --- .github/PULL_REQUEST_TEMPLATE.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 2330377303..595f90d659 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -6,7 +6,7 @@ -## Issue / Notion doc (if applicable) +## Issue @@ -16,3 +16,4 @@ ## Screenshots (if applicable) + From 73567ed655e1fe2a1f3ddf8a35af7afbe4a675f0 Mon Sep 17 00:00:00 2001 From: Adam Gall Date: Wed, 21 Feb 2024 15:06:55 -0500 Subject: [PATCH 3/6] Remove "Bug" title prefix from bug issue template --- .github/ISSUE_TEMPLATE/bugs.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bugs.yml b/.github/ISSUE_TEMPLATE/bugs.yml index 157fb395de..c686f4c002 100644 --- a/.github/ISSUE_TEMPLATE/bugs.yml +++ b/.github/ISSUE_TEMPLATE/bugs.yml @@ -1,7 +1,6 @@ name: Bug description: Report a bug -title: "Bug: " -labels: ["bug"] +labels: ['bug'] body: - type: markdown attributes: From ae1322d08ba426830ae4c71ad1dfce8ff6c07e30 Mon Sep 17 00:00:00 2001 From: Adam Gall Date: Wed, 21 Feb 2024 15:07:04 -0500 Subject: [PATCH 4/6] Add a "Feature requests" template --- .github/ISSUE_TEMPLATE/feature-requests.yml | 22 +++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/feature-requests.yml diff --git a/.github/ISSUE_TEMPLATE/feature-requests.yml b/.github/ISSUE_TEMPLATE/feature-requests.yml new file mode 100644 index 0000000000..4a00f966b9 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature-requests.yml @@ -0,0 +1,22 @@ +name: Feature Request +description: Suggest a feature +labels: ['feature-request'] +body: + - type: markdown + attributes: + value: | + Please give your feature request a short and descriptive title. + - type: textarea + id: overview + attributes: + label: Overview + description: General description of the new feature. + validations: + required: true + - type: textarea + id: info + attributes: + label: Additional Info + description: More context and reasoning, expected implementation details, etc. + validations: + required: false From 8f46eef20e30d914f451a0fb7e078a3a77f4db14 Mon Sep 17 00:00:00 2001 From: Adam Gall Date: Wed, 21 Feb 2024 15:22:57 -0500 Subject: [PATCH 5/6] Update actions in unit-tests.yaml --- .github/workflows/unit-tests.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/unit-tests.yaml b/.github/workflows/unit-tests.yaml index 72e77c9aa7..ca14eb2022 100644 --- a/.github/workflows/unit-tests.yaml +++ b/.github/workflows/unit-tests.yaml @@ -12,16 +12,16 @@ jobs: steps: # Checkout the repository - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 # Set up the required Node.js version - name: Set up node - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' - name: Install dependencies run: npm ci - + - name: Run tests run: npm run test From 8e940c51ef6422ad70bee76796d1ab81b59f2445 Mon Sep 17 00:00:00 2001 From: Adam Gall Date: Wed, 21 Feb 2024 15:32:31 -0500 Subject: [PATCH 6/6] Remove dev environment line from unit test run --- .github/workflows/unit-tests.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/unit-tests.yaml b/.github/workflows/unit-tests.yaml index ca14eb2022..0f3607fab9 100644 --- a/.github/workflows/unit-tests.yaml +++ b/.github/workflows/unit-tests.yaml @@ -8,7 +8,6 @@ on: jobs: vitest: runs-on: ubuntu-latest - environment: dev steps: # Checkout the repository - name: Checkout