Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import NFT token form needs redesign #2606

Open
DarksightKellar opened this issue Dec 6, 2024 · 3 comments
Open

Import NFT token form needs redesign #2606

DarksightKellar opened this issue Dec 6, 2024 · 3 comments
Assignees

Comments

@DarksightKellar
Copy link
Contributor

DarksightKellar commented Dec 6, 2024

The positioning of the helper text and the potential for error text conflict each other:

Screenshot 2024-12-06 at 16 05 04 Screenshot 2024-12-06 at 16 05 31
@xanaramoss
Copy link

xanaramoss commented Dec 6, 2024

@DarksightKellar
I would suggest shifting the grey text down by 4–8 pixels when the alert mode is active.

@DarksightKellar
Copy link
Contributor Author

DarksightKellar commented Dec 20, 2024

Oh. I lost track of this issue. 2 weeks. Yikes.

@xanaramoss I dunno about shifting the hint down on error. It'll cause distracting visual jank as the input goes from valid->error->valid states and the grey text gets pushed down to accommodate for the red text. Plus doing this feels like just deferring the problem to the next guy -- whatever happens to be below the red and grey text. Might also mess up spacing on elements below.

As I'm writing this a crazy-ish thought occurred to me: we could hide the hint text whenever this error shows up. Cz it's like they kinda have to occupy the same visual space.

That or a redesign are only things I'll be happy with lol 😅

EDIT: Another place this design doesn't work out, and actually a good example of why shifting down might not work (notice text button right below the input)
Screenshot 2024-12-20 at 14 13 58

EDIT EDIT: I have to ask, is there nowhere else this input layout style is used? Can't find anywhere else after a quick search. If so I don't see any reason keeping it around, since it then sticks out against all other form inputs and is inconsistent.

@xanaramoss
Copy link

xanaramoss commented Dec 20, 2024

@DarksightKellar I understand your point.
Hiding the helper text could be a good solution, but at the same time, it feels a bit off because the text can actually be helpful for this situation.
I’ll bring this up in the design sync in 30 min to explore redesign possibilities, as no immediate solutions come to mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

3 participants