You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Agreed with @adamgall to pick this up in the backlog later
Assuming this PR just removes the button if not connected with Token. Just so you're aware, this does mean that if you connect wallet, click 'edit roles' and then disconnect and reload the page, you can still go through the flow even when disconnected.
I don't think this is the end of the world as proposal still isn't submittable. It also would mean that the user would have to have a token at that session at some point. But just an fyi, we probably should align on before we approve
Let me know what you both think. Worth fixing or leave it for now?
Perhaps we can create a hook that redirects... somewhere... if the hook is executed in a component and the (possibly disconnected) user isn't able to submit a proposal
Agreed with @adamgall to pick this up in the backlog later
Assuming this PR just removes the button if not connected with Token. Just so you're aware, this does mean that if you connect wallet, click 'edit roles' and then disconnect and reload the page, you can still go through the flow even when disconnected.
see video -- https://decentdao.slack.com/archives/C06QZTUTKRC/p1722006635219679?thread_ts=1722006582.990389&cid=C06QZTUTKRC
I don't think this is the end of the world as proposal still isn't submittable. It also would mean that the user would have to have a token at that session at some point. But just an fyi, we probably should align on before we approve
Let me know what you both think. Worth fixing or leave it for now?
Originally posted by @tomstuart123 in #2182 (comment)
The text was updated successfully, but these errors were encountered: