Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Disconnect' - then carry on editing roles #2183

Open
tomstuart123 opened this issue Jul 26, 2024 · 1 comment
Open

'Disconnect' - then carry on editing roles #2183

tomstuart123 opened this issue Jul 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@tomstuart123
Copy link

Agreed with @adamgall to pick this up in the backlog later

Assuming this PR just removes the button if not connected with Token. Just so you're aware, this does mean that if you connect wallet, click 'edit roles' and then disconnect and reload the page, you can still go through the flow even when disconnected.

see video -- https://decentdao.slack.com/archives/C06QZTUTKRC/p1722006635219679?thread_ts=1722006582.990389&cid=C06QZTUTKRC

I don't think this is the end of the world as proposal still isn't submittable. It also would mean that the user would have to have a token at that session at some point. But just an fyi, we probably should align on before we approve

Let me know what you both think. Worth fixing or leave it for now?

Originally posted by @tomstuart123 in #2182 (comment)

@tomstuart123 tomstuart123 added the enhancement New feature or request label Jul 26, 2024
@tomstuart123 tomstuart123 moved this to Backlog in Decent Jul 26, 2024
@adamgall
Copy link
Member

adamgall commented Aug 2, 2024

Perhaps we can create a hook that redirects... somewhere... if the hook is executed in a component and the (possibly disconnected) user isn't able to submit a proposal

@adamgall adamgall moved this from Backlog to Ready in Decent Aug 2, 2024
@DarksightKellar DarksightKellar self-assigned this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Ready
Development

No branches or pull requests

3 participants