Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Submit and create proposal" button #1512

Closed
adamgall opened this issue Apr 3, 2024 · 1 comment · Fixed by #1524
Closed

"Submit and create proposal" button #1512

adamgall opened this issue Apr 3, 2024 · 1 comment · Fixed by #1524
Assignees
Labels
bug Something isn't working

Comments

@adamgall
Copy link
Member

adamgall commented Apr 3, 2024

Context: #1510 (review)

"Submit and create proposal" button

"Submit and Create Proposal" button IMO should only be clickable if all inputs are populated. In the screenshot below, clicking the button results in an toast error.

What's the effort involved to do this?

Screenshot 2024-04-03 at 8 55 42 AM
@mudrila mudrila moved this to In review in Decent Apr 9, 2024
@mudrila mudrila self-assigned this Apr 9, 2024
@mudrila mudrila added the bug Something isn't working label Apr 9, 2024
@mudrila
Copy link
Contributor

mudrila commented Apr 9, 2024

@adamgall This issue should be resolved in scope of #1524 combined with #1528
The way it works is that it allows you to create proposal from template, even if function name not specified and ethValue is empty or is set to 0 explicitly. Effectively, this will lead to creating proposal that does nothing, but executing such proposal works 🤷
We might include some alert message saying that "executing this proposal is expected to do nothing, since function name and ETH value is not provided"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants