Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design and Build Pricing Service #1388

Closed
adamgall opened this issue Feb 28, 2024 · 1 comment
Closed

Design and Build Pricing Service #1388

adamgall opened this issue Feb 28, 2024 · 1 comment
Assignees
Labels
maintenance Keep the lights on

Comments

@adamgall
Copy link
Member

adamgall commented Feb 28, 2024

We need to build a backend price supplier API.

Here are some requirements:

  • It should include IP-based rate limiting.
  • It should include CORS-based limiting, same origin.
  • It uses CoinGecko's Free Tier API key, which has a limit of 30 requests per minute.
  • Service is stateless with regards to Safes, it doesn't know anything about Safe addresses.
  • Service accepts a list of token addresses (and/or ETH), and responds back with USD value for each token address (and/or ETH).

I see the hard part being satisfying these three things at the same time. As long as number 3 is a should, not a must, we'll be gucci:

  1. Service must always respond to a request in a timely manner (no slower than however much longer a CoinGecko request takes, plus some time for our service to build a response).
  2. Service must, globally, never hit the CoinGecko API more than 30 times in a 1 minute window.
  3. Service should not return stale price data ("staleness" to be tweaked later, lets call it 30 mins for now).
@adamgall adamgall changed the title Design Pricing Service Design and Build Pricing Service Feb 29, 2024
@adamgall
Copy link
Member Author

Closing in favor of #1362

@adamgall adamgall added the maintenance Keep the lights on label Mar 4, 2024
@adamgall adamgall added this to Decent Mar 4, 2024
@adamgall adamgall moved this to Done in Decent Mar 4, 2024
@adamgall adamgall removed this from Decent Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Keep the lights on
Projects
None yet
Development

No branches or pull requests

2 participants