Oops! Couldn't find a Safe...

[adamgall]

Sometimes this message appears when attempting to load a Safe.

In the case of this screenshot, it appeared while on the app.dev.fractalframework.xyz domain. I did not have any wallet connected to the site, so I assume that the default network for the app.dev framework is Goerli, which is referenced in the error message.

I'm opening this issue for two reasons.

1. Why am I being prompted to refresh the page? If a Safe on Goerli doesn't exist at this address, what will refreshing the page accomplish? (i.e., is "refreshing the page" a bandaid fix on top of a deeper data-availability issue?)
2. Why am I being prompted to change the networks in my wallet? I don't have a wallet connected, so I can't change networks.

[tomstuart123]

@adamgall would you agree that point (2) you raised is resolved whilst point (1) is still open

i.e. the app shouldn't now not be unable to open a Safe/DAO when disconnected... but we should still look at how we are handling errors to give more precise feedback.

If a Safe exists but we're on a wrong chain, I think we should prompt them. If there has been an error, I think we should highlight the data availability issue and ask for a refresh.

Thoughts?

[adamgall]

@tomstuart123

Let me try to tease out my response a bit, I think there are a couple of things being discussed here...

would you agree that point (2) you raised is resolved whilst point (1) is still open

I would not agree that point 2 is resolved, completely:

Why am I being prompted to change the networks in my wallet? I don't have a wallet connected, so I can't change networks.

Example: With no wallet connected to the app, load up https://app.fractalframework.xyz/daos/0xD1745a9e3A84656480C1B0b0F9D2a1Bf91b42917. You'll see this:

I'm being asked to change networks in my wallet, which isn't connected.

But to comment on your individual statements:

i.e. the app shouldn't now not be unable to open a Safe/DAO when disconnected...

The app was unable to open this Safe while disconnected, but specifically because when disconnected the production deployment defaults to Mainnet (with no way to switch that IN APP), and the Safe attempting to be loaded exists on Sepolia.

but we should still look at how we are handling errors to give more precise feedback.

I agree with this. Unfortunately, I'm not sure how much more direction we can give to the user in this case... more on that here:

If a Safe exists but we're on a wrong chain, I think we should prompt them.

It is not trivial for the app to determine this. The app is connected to one chain at a time (inclusive of node RPC connection, Safe API, Alchemy API, etc etc). Either the address is a valid Safe on that chain, or not. There are some bandaid things we could do to "check" if the given address is valid on any other supported networks, but without a wallet connected we can't instruct the user to switch to that network in app. The root things to start fixing here would include:

• allowing the user to switch which network the app is connected to whether or not they have a wallet connected
• allowing the app to namespace a Safe to a network with the address itself, much like how the Safe app works
  • https://...?safe=sep:0xD1745a9e3A84656480C1B0b0F9D2a1Bf91b42917
  • This would allow the app compare what the user is trying to do, with how the app is currently configured/connected, and allow us to give more relevant feedback.

If there has been an error, I think we should highlight the data availability issue and ask for a refresh.

Soft agree, but I still don't think that's a very good user experience. This should be happening very rarely.