Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing lib size #37

Closed
charliermarsh opened this issue Apr 20, 2016 · 4 comments
Closed

Reducing lib size #37

charliermarsh opened this issue Apr 20, 2016 · 4 comments

Comments

@charliermarsh
Copy link

Thanks for open-sourcing this--really useful stuff.

I'm noticing that while unminified oauth-1.0a.js is just 7 KB, including this library in my minified Webpack bundle adds 60 KB in total to the bundle size. This is almost entirely due to the transitive dependency on CryptoJS.

Would there be any interest in either carving our a smaller crypto dependency (oauth-1.0a.js only uses three functions from CryptoJS) or providing a means by which to inject the crypto dependency such that clients could package their own smaller crypto libraries?

Cheers.

@thisconnect
Copy link

Related brix/crypto-js#60

@ddo
Copy link
Owner

ddo commented Aug 15, 2016

a PR is welcome

@ddo
Copy link
Owner

ddo commented Sep 11, 2016

just release new major version of oauth-1.0a: 2.0.0 read the changelog here
https://github.com/ddo/oauth-1.0a/releases/tag/2.0.0

@ddo ddo closed this as completed Sep 11, 2016
@thisconnect
Copy link

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants