Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter fuzzywuzzy ratio #1

Open
dwu402 opened this issue Apr 29, 2020 · 0 comments · May be fixed by #2
Open

Smarter fuzzywuzzy ratio #1

dwu402 opened this issue Apr 29, 2020 · 0 comments · May be fixed by #2

Comments

@dwu402
Copy link

dwu402 commented Apr 29, 2020

Parsing two similar expecting files where one is a substring of another causes problems when using fuzzywuzzy's partial_ratio.

This is particularly problematic in the _load method of Project when selecting the best matching expecting.

Example

expecting = ['functions.py', 'test_functions.py']
file = 'student123456_test_functions.py'
ratios = [unicity._check_fuzzy_ratio(file, expect) for expect in expecting]

>>> ratios = [100, 100]

Request

Use a different method for fuzzy compare that deals with substring collisions in expecting

dwu402 pushed a commit to dwu402/unicity that referenced this issue Apr 29, 2020
dwu402 added a commit to dwu402/unicity that referenced this issue Apr 29, 2020
@dwu402 dwu402 linked a pull request Apr 29, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant