Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make serde_bytes a mandatory dependency #665

Closed
zeenix opened this issue Feb 28, 2024 · 2 comments
Closed

Make serde_bytes a mandatory dependency #665

zeenix opened this issue Feb 28, 2024 · 2 comments
Labels
api break zvariant Issues/PRs related to zvariant crate
Milestone

Comments

@zeenix
Copy link
Contributor

zeenix commented Feb 28, 2024

Given how much faster serde_bytes use makes (de)serialization of byte arrays, we should make it mandatory and advertise it more (e.g with examples in the crate docs).

Since turning an optional dependency into mandatory, breaks existing code, we can't just do it in non-major version updates.

@zeenix zeenix added api break zvariant Issues/PRs related to zvariant crate labels Feb 28, 2024
@zeenix zeenix added this to the zvariant-5 milestone Feb 28, 2024
@zeenix
Copy link
Contributor Author

zeenix commented Feb 28, 2024

Since turning an optional dependency into mandatory, breaks existing code, we can't just do it in non-major version updates.

Actually it might be possible to do this by adding a dummy feature by the same name. We'll see when I get to implement this.

@zeenix
Copy link
Contributor Author

zeenix commented Oct 7, 2024

Hmm.. thinking more about this, I don't think we should do this. Not everyone needs to (de)serialize byte sequences directly and it's not good to mandate another dep. However we should:

@zeenix zeenix closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api break zvariant Issues/PRs related to zvariant crate
Projects
None yet
Development

No branches or pull requests

1 participant