From 9b3c4e0526f1d413e8d329ca3666911d67f7b95a Mon Sep 17 00:00:00 2001 From: Frantisek Sumsal Date: Fri, 22 Sep 2023 22:20:19 +0200 Subject: [PATCH 1/2] rand: appease clang-12 and later [11/28] Compiling C object dfuzzer.p/src_rand.c.o ../src/rand.c:541:17: warning: suspicious concatenation of string literals in an array initialization; did you mean to separate the elements with a comma? [-Wstring-concatenation] "%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n", ^ ../src/rand.c:540:17: note: place parentheses around the string literal to silence warning "%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n" \ ^ 1 warning generated. Reported in https://github.com/dbus-fuzzer/dfuzzer/pull/63#issuecomment-1731324397 --- src/rand.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/rand.c b/src/rand.c index fab8610..9f7df51 100644 --- a/src/rand.c +++ b/src/rand.c @@ -537,8 +537,8 @@ int df_rand_string(gchar **buf, guint64 iteration) static const char *test_strings[] = { "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", "%s%s%s%s%s%s%s%s%s%n%s%n%n%n%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s", - "%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n" \ - "%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n", + ("%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n" + "%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n%n"), "bomb(){ bomb|bomb & }; bomb", ":1.285", "org.freedesktop.foo", From eb8e3c50ce0571dfa027f59cabe31a217125ba66 Mon Sep 17 00:00:00 2001 From: Frantisek Sumsal Date: Fri, 22 Sep 2023 22:28:18 +0200 Subject: [PATCH 2/2] ci: switch all jobs to the ubuntu-latest images --- .github/workflows/build.yml | 4 ++-- .github/workflows/codeql.yml | 2 +- .github/workflows/coverity.yml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1277368..8b17b13 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -15,7 +15,7 @@ permissions: jobs: build: - runs-on: ubuntu-20.04 + runs-on: ubuntu-latest concurrency: group: ${{ github.workflow }}-${{ toJSON(matrix.env) }}-${{ github.ref }} cancel-in-progress: true @@ -69,7 +69,7 @@ jobs: - name: Test run: .github/workflows/run-tests.sh coveralls: - runs-on: ubuntu-20.04 + runs-on: ubuntu-latest concurrency: group: ${{ github.workflow }}-${{ github.ref }} cancel-in-progress: true diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index a2ab36f..ede4093 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -17,7 +17,7 @@ permissions: jobs: analyze: name: Analyze - runs-on: ubuntu-22.04 + runs-on: ubuntu-latest concurrency: group: ${{ github.workflow }}-${{ matrix.language }}-${{ github.ref }} cancel-in-progress: true diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml index b5c3728..d2e46b2 100644 --- a/.github/workflows/coverity.yml +++ b/.github/workflows/coverity.yml @@ -11,7 +11,7 @@ permissions: jobs: build: - runs-on: ubuntu-20.04 + runs-on: ubuntu-latest if: github.repository == 'dbus-fuzzer/dfuzzer' env: COVERITY_SCAN_TOKEN: "${{ secrets.COVERITY_SCAN_TOKEN }}"