Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove beta callout #4428

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Remove beta callout #4428

merged 2 commits into from
Nov 9, 2023

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Nov 9, 2023 •
edited
Loading

What are you changing in this pull request and why?

Checklist

Removing or renaming existing pages (delete if not applicable):

  • [ ] Remove page from website/sidebars.js n/a to partial file
  • [ ] Add an entry website/static/_redirects n/a to partial file

@nghi-ly nghi-ly requested a review from a team as a code owner November 9, 2023 16:02
@vercel Vercel
Copy link

vercel bot commented Nov 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 4:58pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs and removed content Improvements or additions to content labels Nov 9, 2023
joellabes
joellabes approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm! One change before merging: There are four places that depend on the old anchor (#set-as-production-environment-beta)

Can you update those to the new anchor too? in future it's probably worth us setting a custom heading ID when we have beta functionality, so that it keeps working post-launch. (I'll go mention this in the product docs channel!)

@nghi-ly
Copy link
Contributor Author

nghi-ly commented Nov 9, 2023 •
edited
Loading

thank you, @joellabes , for flagging! weird, i would've expected that be caught by our link checker.

@joellabes
Copy link
Contributor

i would've expected that would've been caught by our link checker.

That only checks that the page loads correctly - people will be dropped at the top of the page but it still exists so it passes

@nghi-ly
Copy link
Contributor Author

nghi-ly commented Nov 9, 2023

@joellabes : ah that's right, it's not a 404. fixed the links, thanks!

@nghi-ly nghi-ly merged commit 901add3 into current Nov 9, 2023
7 checks passed
@nghi-ly nghi-ly deleted the ly-docs-remove-beta branch November 9, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joellabes joellabes joellabes approved these changes

Assignees
No one assigned
Labels
Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nghi-ly @joellabes