Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add venv to install instructions page #3960

Merged
merged 8 commits into from
Aug 21, 2023
Merged

Conversation

greg-mckeon
Copy link
Contributor

From a convo with @jtcohen6, we'd really like all of our core users to be using a virtual environment of some kind. This makes that recommendation more explicit by moving it from a collapsed tab to the install page itself.

@greg-mckeon greg-mckeon requested a review from a team as a code owner August 21, 2023 15:47
@github-actions github-actions bot added the content Improvements or additions to content label Aug 21, 2023
@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 037d531
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64e3d28b940ae90009720d14
😎 Deploy Preview https://deploy-preview-3960--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the size: small This change will take 1 to 2 days to address label Aug 21, 2023
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greg-mckeon Just a few minor requests!

website/docs/docs/core/pip-install.md Outdated Show resolved Hide resolved
python3 -m venv dbt-env # create the environment
```

If you install dbt in a virtual environment, you need to reactivate that same virtual environment each time you create a shell window or session.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you install dbt in a virtual environment, you need to reactivate that same virtual environment each time you create a shell window or session.
2. Reactivate the dbt virtual environment with every new session. When you install dbt in a virtual environment, you need to reactivate that same virtual environment each time you open a new shell window or session.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this up a bit to be shorter.

website/docs/docs/core/pip-install.md Outdated Show resolved Hide resolved
website/docs/docs/core/pip-install.md Outdated Show resolved Hide resolved
website/docs/docs/core/pip-install.md Outdated Show resolved Hide resolved
@greg-mckeon
Copy link
Contributor Author

Updated, feel free to submit if it looks good!

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@runleonarun runleonarun enabled auto-merge (squash) August 21, 2023 21:10
@runleonarun runleonarun merged commit 6bcf0c2 into current Aug 21, 2023
@runleonarun runleonarun deleted the venv-instructions branch August 21, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants