Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sl-jdbc.md #3953

Merged
merged 26 commits into from
Sep 19, 2023
Merged

Update sl-jdbc.md #3953

merged 26 commits into from
Sep 19, 2023

Conversation

rpourzand
Copy link
Contributor

@rpourzand rpourzand commented Aug 18, 2023

  • update to filter list for WHERE
  • updates for the ability to get the agg_time_dimension name for measures
  • updates for the ability to get queryable granularities for more than just a primary time dim

What are you changing in this pull request and why?

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

- update to filter list for WHERE
- update to examples with where
- updates for using Dimension() AND TimeDimension() in where clause
@rpourzand rpourzand requested a review from a team as a code owner August 18, 2023 22:57
@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 826b267
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64fedd5c82a4de00085d8598
😎 Deploy Preview https://deploy-preview-3953--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address and removed content Improvements or additions to content labels Aug 18, 2023
@@ -215,21 +215,33 @@ select * from {{

### Query with where filters

Where filters have three components:
Where filters in API allow for a filter list or string. We recommend using the filter list for production application as this format will realize all benefits from predicate pushdown where possible.
Copy link
Contributor

@mirnawong1 mirnawong1 Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpourzand , what does predicate mean in this sentence?

Suggested change
Where filters in API allow for a filter list or string. We recommend using the filter list for production application as this format will realize all benefits from predicate pushdown where possible.
In the API, you can use where filters either as a filter list or string. For production applications, it's better to use a filter list. This format helps you take advantage of all the benefits from the predicate pushdown where possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So a predicate is just an expression to determine what rows in a database apply to a particular query. For example, if I filter in a WHERE clause on a particular dimension value, the database is basically going to search to determine what values in the DB apply to this query. If this can be pushed down to the database (predicate pushdown)), it's much faster.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could link out some generic docs on predicate pushdown.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Predicate Pushdown points to the where or filter clause which affects the number of rows returned. It basically relates to which rows will be filtered, not which columns. For this reason, while applying the filter on a nested column as ‘library.books’ to merely return records with the values that are not null, the predicate pushdown function will make parquet read blocks that contain no null values for the specified column.

@github-actions github-actions bot added the content Improvements or additions to content label Aug 23, 2023
@mirnawong1
Copy link
Contributor

lgtm!

@rpourzand rpourzand requested a review from DevonFulcher August 28, 2023 22:22
mirnawong1 and others added 3 commits August 29, 2023 09:51
updated with a queryable granularity example
adding the query Courtney introduced to get the name of the agg time dimension
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Aug 29, 2023
@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 9:45pm

@mirnawong1
Copy link
Contributor

waiting until roxi is back from ooo

removing one set of changes from this PR since it won't be shipped until a little later
@rpourzand
Copy link
Contributor Author

hey @mirnawong1 I edited this one to remove some things that are still in flight, so pending your final review it can be shipped

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @rpourzand ! happy to merge this for you if you're ok with it! ✨

@mirnawong1 mirnawong1 merged commit a757e5a into current Sep 19, 2023
7 checks passed
@mirnawong1 mirnawong1 deleted the rpourzand-jdbc-updates-where-filters branch September 19, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants