-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add callout for net new snapshots #6521
base: current
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Grace Goheen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the original issue Doug opened was about new snapshots configs (like dbt_valid_to_current
and snapshot_meta_column_names
) not the "new YAML" spec - can we adjust this PR accordingly?
thanks @graciegoheen , i did meet with @dbeatty10 last week and thought he meant the new yaml spec. will loop Doug to confirm to make sure before i make further changes. |
@@ -150,11 +150,27 @@ Configurations can be applied to snapshots using the [YAML syntax](/docs/build/s | |||
|
|||
</Tabs> | |||
|
|||
### Snapshot configuration migration | |||
|
|||
The latest snapshot YAML configurations introduced in dbt v1.9 (such as [`snapshot_meta_column_names`](/reference/resource-configs/snapshot_meta_column_names) and [`dbt_valid_to_current`](/reference/resource-configs/dbt_valid_to_current)) are best suited for new snapshots. For existing snapshots, we recommend the following to avoid any inconsistencies in your snapshots: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest snapshot YAML configurations introduced in dbt v1.9 (such as [`snapshot_meta_column_names`](/reference/resource-configs/snapshot_meta_column_names) and [`dbt_valid_to_current`](/reference/resource-configs/dbt_valid_to_current)) are best suited for new snapshots. For existing snapshots, we recommend the following to avoid any inconsistencies in your snapshots: | |
The latest snapshot configurations introduced in dbt v1.9 (such as [`snapshot_meta_column_names`](/reference/resource-configs/snapshot_meta_column_names) and [`dbt_valid_to_current`](/reference/resource-configs/dbt_valid_to_current)) are best suited for new snapshots. For existing snapshots, we recommend the following to avoid any inconsistencies in your snapshots: |
@@ -0,0 +1 @@ | |||
Define snapshots using the latest [YAML configurations](/docs/build/snapshots#configuring-snapshots), available in Versionless dbt Cloud and Core v1.9 and higher, in the `snapshot` directory file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this about the YAML syntax?
I think we're getting two separate things muddied:
- starting in 1.9 you can define snapshots in yaml
- starting in 1.9 there are a handful of new configs that you can use, we recommend only using those configs on new snapshots or if you use them on old snapshots you will need to migrate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok thank you for clarifying! resovled this by having the below for snapshot specific configs and general configs:
snapshot specific configs
Starting from Versionless and Core v1.9, defining snapshots in a .sql
file using a config block is a legacy method. You can define snapshots in YAML format using the latest snapshot-specific configurations. For new snapshots, we recommend using these latest configs. If applying them to existing snapshots, you'll need to migrate over.
general configs
Starting from Versionless and Core v1.9, defining snapshots in a .sql
file using a config block is a legacy method. You can define snapshots in YAML format using the latest configurations. You can also continue using the legacy method for existing snapshots, but we recommend migrating over to the latest YAML format for better readability and maintainability.
hey @graciegoheen - made some add'l tweaks and ready for your review when you can! |
Adding a callout to snapshot config page to clarify the new yaml config for net new snapshots. exisitng config snapshots can continue using config block, however added guidance on what to do if they want to migrate to new yaml spec.
Resolves #6374
🚀 Deployment available! Here are the direct links to the updated files: