Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearer description for "plus" graph operator (that includes the selected model itself) #3979

Closed
1 task done
graciegoheen opened this issue Aug 25, 2023 · 0 comments · Fixed by #4861
Closed
1 task done

Clearer description for "plus" graph operator (that includes the selected model itself) #3979

graciegoheen opened this issue Aug 25, 2023 · 0 comments · Fixed by #4861
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@graciegoheen
Copy link
Collaborator

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/reference/node-selection/graph-operators

What part(s) of the page would you like to see updated?

Update the description of the "plus" graph operator from:

If placed at the front of the model selector, + will select all parents of the selected model. If placed at the end of the string, + will select all children of the selected model.

to:

If placed at the front of the model selector, + will select all parents of the selected model and the model itself. If placed at the end of the string, + will select all children of the selected model and the model itself.

as discussed in this core issue.

Additional information

No response
@graciegoheen graciegoheen added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Aug 25, 2023
@runleonarun runleonarun added the dbt Core The changes proposed in this issue relate to dbt Core label Aug 29, 2023
@dbeatty10 dbeatty10 mentioned this issue Feb 6, 2024
Merged
1 task
mirnawong1 added a commit that referenced this issue Feb 6, 2024
@mirnawong1
The "plus" graph operator also selects the model itself (#4861)
4e945de 
[Preview](https://docs-getdbt-com-git-dbeatty-plus-operator-dbt-labs.vercel.app/reference/node-selection/graph-operators)

## What are you changing in this pull request and why?

resolves #3979 by updating the description of the "plus" graph operator
from:

> If placed at the front of the model selector, + will select all
parents of the selected model. If placed at the end of the string, +
will select all children of the selected model.

to:

> If placed at the front of the model selector, + will select all
parents of the selected model and the model itself. If placed at the end
of the string, + will select all children of the selected model and the
model itself.

as discussed in
dbt-labs/dbt-core#8340 (comment).

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

The "plus" graph operator also selects the model itself dbt-labs/docs.getdbt.com
2 participants
@runleonarun @graciegoheen