Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to be omitted if using authenticator #866

Closed
wants to merge 1 commit into from

Conversation

MasterOdin
Copy link

resolves #726
docs dbt-labs/docs.getdbt.com/#

Problem

Currently, when using authenticator: oauth, you have to pass it client id & secret & token which is enough to authenticate, but also need to still pass user (which is validated if it has a value).

Solution

This PR makes user optional so that it can be omitted when using an authenticator, otherwise an error will be raised.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@MasterOdin MasterOdin requested a review from a team as a code owner December 14, 2023 16:04
Copy link

cla-bot bot commented Dec 14, 2023

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @MasterOdin

@MasterOdin MasterOdin closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-783] [Feature] Allow user to be omitted if using oauth authenticator
1 participant