Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove trigger on label for functional tests #727

Merged
merged 1 commit into from
Sep 24, 2024
Merged

chore: remove trigger on label for functional tests #727

merged 1 commit into from
Sep 24, 2024

Conversation

nicor88
Copy link
Contributor

@nicor88 nicor88 commented Sep 24, 2024

Description

Now that dbtlabs has taken over, and a proper AWS exists under the scene, we can remove the trigger based on a label for functional tests running on PRs.

Checklist

  • You followed contributing section
  • You kept your Pull Request small and focused on a single feature or bug fix.
  • You added unit testing when necessary
  • You added functional testing when necessary

@nicor88 nicor88 requested a review from a team as a code owner September 24, 2024 07:25
@nicor88
Copy link
Contributor Author

nicor88 commented Sep 24, 2024

@colin-rogers-dbt please have a look.

@colin-rogers-dbt colin-rogers-dbt merged commit 78fae87 into dbt-labs:main Sep 24, 2024
12 checks passed
@nicor88 nicor88 deleted the chore/remove_trigger_label_ci branch September 25, 2024 06:46
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Dec 2, 2024
Merged
4 tasks
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Dec 9, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicor88 @colin-rogers-dbt