Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telephone-line-accent-* face won't show propertized strings correctly #67

Open
shackra opened this issue Apr 15, 2018 · 3 comments · May be fixed by #119
Open

telephone-line-accent-* face won't show propertized strings correctly #67

shackra opened this issue Apr 15, 2018 · 3 comments · May be fixed by #119

Comments

@shackra
Copy link

shackra commented Apr 15, 2018

I've been debugging this for a while thinking this is fault of all-the-icons package, but by accident I found that accent face won't respect propertized strings, in the following screenshot you can see something like a cloud and at its right an exclamation mark, the icons are supposed to be the same --an exclamation mark inside a circle-- but on the accent "side" the character is not rendered propertly using the FontAwesome font, take a look:

captura de pantalla de 2018-04-14 17-51-11

Since in the source code accent is composed of two faces that inherits from the mode-line face we should see improperly shown characters on the mode-line sans telephone-line-mode, right? wrong!:

captura de pantalla de 2018-04-14 18-00-57

The check inside a circle, the exclamation mark inside a red-ish triangle and the Git inside a square are shown perfectly.

This is what describe-face RET mode-line RET shows for my Emacs configuration:

Face: mode-line (sample) (customize this face)

Documentation:
Basic mode line face for selected window.

Defined in ‘faces.el’.

           Family: unspecified
          Foundry: unspecified
            Width: unspecified
           Height: unspecified
           Weight: unspecified
            Slant: unspecified
       Foreground: #F8F8F0
DistantForeground: unspecified
       Background: #49483E
        Underline: unspecified
         Overline: unspecified
   Strike-through: unspecified
              Box: nil
          Inverse: unspecified
          Stipple: unspecified
             Font: unspecified
          Fontset: unspecified
          Inherit: unspecified
shackra added a commit to shackra/emacs that referenced this issue Apr 15, 2018
Se ha sacado las cadenas de texto con tipografía de all-the-icons de las areas marcadas con `accent`
de Telephone-line debido a un bug posiblemente relacionado con las caras `telephone-line-accent-*`

También se refactorizo código relacionado al establecimiento de la cara para cadenas de texto que
usan la tipografía de Font Awesome con la nueva función `shackra-faicon-icon`.

- dbordak/telephone-line#67
@dbordak
Copy link
Owner

dbordak commented Apr 15, 2018

Yeah, I'm aware of this but I'm not sure that there's any way I can fix it. If you propertize a string, it loses all its previous properties, and the colored segments (accent and evil) work by propertizing them.

@dbordak
Copy link
Owner

dbordak commented Apr 15, 2018

(my personal solution is to put the segments where this sort of thing matters into a nil supersegment, but I dunno if that'll work for you)

@shackra
Copy link
Author

shackra commented Apr 15, 2018

(It actually does, I did that as a workaround)

rosekunkel added a commit to rosekunkel/telephone-line that referenced this issue Feb 26, 2021
Fixes dbordak#67 and dbordak#94. Confirmed to work with all-the-icons.
@rosekunkel rosekunkel linked a pull request Feb 26, 2021 that will close this issue
deriamis pushed a commit to deriamis/telephone-line that referenced this issue Jan 7, 2024
Fixes dbordak#67 and dbordak#94. Confirmed to work with all-the-icons.

(cherry picked from commit d70a2ba)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants