Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend set sync to turn syncing on/off for a user per channel #129

Open
laurelstreng opened this issue May 16, 2022 · 5 comments
Open

Extend set sync to turn syncing on/off for a user per channel #129

laurelstreng opened this issue May 16, 2022 · 5 comments

Comments

@laurelstreng
Copy link

laurelstreng commented May 16, 2022

  • I have a Slack channel specifically for a run group
  • I have a running specific Strava Run Group/Club
  • Slava has been connected to the Slack channel successfully and workouts from members are appearing in the channel. However it appears that any type of workout from users are showing in the channel
@laurelstreng laurelstreng changed the title Strava Club showing all workouts instead of only the club fitness type Strava Club showing all workout types instead of only the club fitness type May 16, 2022
@dblock
Copy link
Owner

dblock commented May 16, 2022

Do I read this correctly that you expected only a certain type of workout in the channel? Could you please post some examples of what is showing up (maybe screenshots) that you don't expect to see?

@laurelstreng
Copy link
Author

@dblock so yes, I expected that if I connected a Strava Club to a channel that it would only post the workouts from the Club (in this case it's a Running specific club).

An example of what i'm seeing is that any type of workout from members in the Strava Club are appearing in the channel.
In this screenshot there is a Stand Up Paddle Boarding working that posted from myself:
Screen Shot 2022-05-16 at 9 46 28 AM

@laurelstreng
Copy link
Author

laurelstreng commented May 16, 2022

Additional note: Members of this running Slack channel did connect their individual Strava accounts to Slava. Is that possibly why all different types of workouts are appearing in the running Slack channel?

Maybe we're just using it wrong?

@dblock
Copy link
Owner

dblock commented May 16, 2022

Additional note: Members of this running Slack channel did connect their individual Strava accounts to Slava. Is that possibly why all different types of workouts are appearing in the running Slack channel?

That's why. Slava is smart enough to reconcile two activities as duplicates and only post it once (the user's) but it's also sending your activities for the ride. Instead of disconnecting, right now you can only disable your own sync with set sync false. Unfortunately that will disable your sync globally, there's no way to do it just in this one channel.

We thus have a few feature requests.

Currently the code checks whether the user is in-channel to notify about an activity here. It would need to get smarter and allow users to enable sync not just globally but per-channel.

Does it make sense? Want to try and implement it? :)

@dblock dblock changed the title Strava Club showing all workout types instead of only the club fitness type Extend set sync to turn syncing on/off for a user per channel May 16, 2022
@laurelstreng
Copy link
Author

@dblock the set sync false definitely worked, thanks for all this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants