From 6592e1e3fa52f1f5209fbb3bb43d8e7403e34a2e Mon Sep 17 00:00:00 2001
From: Maximilian Franzke <787658+mfranzke@users.noreply.github.com>
Date: Thu, 20 Oct 2022 15:58:24 +0200
Subject: [PATCH] fix: cut off overflow-menu in table cells (#106)

* chore: template simplification

we obviously only need the condition around the table cell head element

* feat: providing a table overflow-menu usage example

* chore: be more sensible on the included components regarding setting overflow
---
 .github/workflows/default.yml                               | 6 +++---
 .../_patterns/02-components/overflow-menu/overflow-menu.hbs | 2 +-
 .../02-components/overflow-menu/overflow-menu.json          | 1 -
 .../overflow-menu/overflow-menu~opposite-position.json      | 1 -
 source/_patterns/02-components/table/table.hbs              | 1 +
 source/_patterns/02-components/table/table.scss             | 5 ++++-
 .../_patterns/02-components/table/table~overflow-menu.json  | 3 +++
 7 files changed, 12 insertions(+), 7 deletions(-)
 create mode 100644 source/_patterns/02-components/table/table~overflow-menu.json

diff --git a/.github/workflows/default.yml b/.github/workflows/default.yml
index 510434dd0e..82ef1271a4 100644
--- a/.github/workflows/default.yml
+++ b/.github/workflows/default.yml
@@ -4,8 +4,8 @@ on:
   pull_request:
   push:
     branches:
-      - 'main'
-      - 'dbux-3'
+      - "main"
+      - "dbux-3"
 
 jobs:
   init:
@@ -26,7 +26,7 @@ jobs:
   build:
     uses: ./.github/workflows/01-build.yml
     needs: [init]
-    
+
   checks-done:
     runs-on: ubuntu-latest
     steps:
diff --git a/source/_patterns/02-components/overflow-menu/overflow-menu.hbs b/source/_patterns/02-components/overflow-menu/overflow-menu.hbs
index 01a4d9d886..0b7d74ec93 100644
--- a/source/_patterns/02-components/overflow-menu/overflow-menu.hbs
+++ b/source/_patterns/02-components/overflow-menu/overflow-menu.hbs
@@ -1,4 +1,4 @@
-<details class="{{ patternName }}{{ styleModifier }}"{{#if linkEntries }} role="navigation"{{/if }}{{#if oppositePosition}} data-horizontal-position="opposite"{{/if }}>
+<details class="{{#if patternName }}{{ patternName }}{{else}}cmp-overflow-menu{{/if }}{{ styleModifier }}"{{#if linkEntries }} role="navigation"{{/if }}{{#if oppositePosition}} data-horizontal-position="opposite"{{/if }}>
 	<summary>{{ summary }}</summary>
 	{{#if linkEntries }}<ul role="group">{{else}}<menu type="toolbar">{{/if }}
 		{{#if linkEntries }}
diff --git a/source/_patterns/02-components/overflow-menu/overflow-menu.json b/source/_patterns/02-components/overflow-menu/overflow-menu.json
index 47ecac0cc4..bb2b814c84 100644
--- a/source/_patterns/02-components/overflow-menu/overflow-menu.json
+++ b/source/_patterns/02-components/overflow-menu/overflow-menu.json
@@ -1,5 +1,4 @@
 {
-	"patternName": "cmp-overflow-menu",
 	"id": "menu01",
 	"entry01": "Modify",
 	"entry02": "Delete",
diff --git a/source/_patterns/02-components/overflow-menu/overflow-menu~opposite-position.json b/source/_patterns/02-components/overflow-menu/overflow-menu~opposite-position.json
index 1e9f1a19bd..ea53f0d4e8 100644
--- a/source/_patterns/02-components/overflow-menu/overflow-menu~opposite-position.json
+++ b/source/_patterns/02-components/overflow-menu/overflow-menu~opposite-position.json
@@ -1,5 +1,4 @@
 {
-	"patternName": "cmp-overflow-menu",
 	"id": "menu04",
 	"entry01": "Modify",
 	"entry02": "Delete",
diff --git a/source/_patterns/02-components/table/table.hbs b/source/_patterns/02-components/table/table.hbs
index 0ffb0fa046..3e1fb33514 100644
--- a/source/_patterns/02-components/table/table.hbs
+++ b/source/_patterns/02-components/table/table.hbs
@@ -21,6 +21,7 @@
 				{{#if ../rowtitle }}<th scope="row">table header</th>{{/if }}
 				<td{{#if @first }}{{#if ../icon}} data-icon="{{ ../icon }}"{{/if }}{{/if }}>{{{ text01 }}}</td>
 				<td>{{{ text02 }}}</td>
+				{{#if ../overflowMenu }}<td>{{> components-overflow-menu entry01="Edit" entry02="Delete" }}</td>{{/if }}
 			</tr>
 		{{/each }}
 	</tbody>
diff --git a/source/_patterns/02-components/table/table.scss b/source/_patterns/02-components/table/table.scss
index d252a45011..82af0d957f 100644
--- a/source/_patterns/02-components/table/table.scss
+++ b/source/_patterns/02-components/table/table.scss
@@ -43,8 +43,11 @@
 		vertical-align: inherit;
 
 		&:hover {
-			overflow: auto;
 			resize: horizontal;
+
+			&:not(:has(.cmp-overflow-menu)) {
+				overflow: auto;
+			}
 		}
 	}
 
diff --git a/source/_patterns/02-components/table/table~overflow-menu.json b/source/_patterns/02-components/table/table~overflow-menu.json
new file mode 100644
index 0000000000..02f3940f7b
--- /dev/null
+++ b/source/_patterns/02-components/table/table~overflow-menu.json
@@ -0,0 +1,3 @@
+{
+	"overflowMenu": true
+}