Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: mark only portals that could be upgraded by the Player himself #22

Open
schentuu opened this issue Apr 4, 2013 · 1 comment

Comments

@schentuu
Copy link

schentuu commented Apr 4, 2013

Because i'm totally new to github, i don't want to fork or branche your code to suggest any changes.
Just a small suggestion for your "iitc: upgradeablePortals"-script:

In version 0.2.1 it shows all portals that could be upgraded to playerlevel-1
What do you think about marking only the portals, that could be upgraded by the player himself?

This is done with a very small change in line 128
Just replace
if(possibleLevel >= playerLevel-1) {
with
if(possibleLevel > portal.options.level) {

@lorenzhs
Copy link
Contributor

There clearly are different opinions on what this plugin should show - personally, I'd like to see only those portals where I can upgrade the portal to a new level. @cmile seems to like the current solution with those portals that I am interested in marked with a different marker. You on the other hand would like to see all upgradeable portals, even those of lower levels.

A way to make this configurable would really be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants