Skip to content

Commit

Permalink
chore: workspace-project image fixes (#623)
Browse files Browse the repository at this point in the history
- Correctly set the user in the Dockerfile
- Fix devcontainer CLI install
- Change CMD to ENTRYPOINT in Dockerfile

Signed-off-by: Toma Puljak <[email protected]>
  • Loading branch information
Tpuljak authored Jun 3, 2024
1 parent ada9000 commit 07f3e32
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion hack/project_image/.devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"ghcr.io/devcontainers/features/node:1": {},
"ghcr.io/devcontainers-contrib/features/typescript:2": {},
"ghcr.io/wxw-matt/devcontainer-features/command_runner:latest": {
"devcontainers": "npm install -g @devcontainers/cli"
"command1": "npm install -g @devcontainers/cli"
}
},
"overrideFeatureInstallOrder": [
Expand Down
4 changes: 3 additions & 1 deletion hack/project_image/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,6 @@ FROM ubuntu:22.04
RUN apt update -y && \
apt install curl libgit2-1.1 -y

CMD ["tail", "-f", "/dev/null"]
USER daytona

ENTRYPOINT ["tail", "-f", "/dev/null"]

0 comments on commit 07f3e32

Please sign in to comment.