From 6bb10c194a5d0fea02821edf166667d020d4d384 Mon Sep 17 00:00:00 2001 From: hipitihop Date: Thu, 7 Apr 2016 19:07:17 +1000 Subject: [PATCH 1/3] Bump deps [com.andrewmcveigh/cljs-time "0.4.0"] [figwheel "0.5.0-6"] [lein-cljsbuild "1.1.2"] [lein-ancient "0.6.7"] - correct :closure-defines to "goog.DEBUG" - also see deps issues #95 & #96 --- project.clj | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/project.clj b/project.clj index 71f0efbb..b37838a5 100644 --- a/project.clj +++ b/project.clj @@ -4,7 +4,7 @@ ;; --------------------------------------------------------------------------------------- -(defproject re-com "0.8.0" +(defproject re-com "0.9.0-SNAPSHOT" :description "Reusable UI components for Reagent" :url "https://github.com/Day8/re-com.git" :license {:name "MIT"} @@ -12,7 +12,7 @@ :dependencies [[org.clojure/clojure "1.7.0"] [org.clojure/clojurescript "1.7.145"] [reagent "0.5.1"] - [com.andrewmcveigh/cljs-time "0.3.14"]] + [com.andrewmcveigh/cljs-time "0.4.0"]] ;:plugins [[lein-unpack-resources "0.1.1"]] ; @@ -29,15 +29,15 @@ :profiles {:dev {:dependencies [[clj-stacktrace "0.2.8"] [alandipert/storage-atom "1.2.4" ] - [figwheel "0.4.1"] + [figwheel "0.5.0-6"] [spellhouse/clairvoyant "0.0-48-gf5e59d3"] [secretary "1.2.3"]] - :plugins [[lein-cljsbuild "1.1.1-SNAPSHOT"] - [lein-figwheel "0.4.1"] + :plugins [[lein-cljsbuild "1.1.2"] + [lein-figwheel "0.5.0-6"] [lein-shell "0.5.0"] [com.cemerick/clojurescript.test "0.3.3"] [lein-s3-static-deploy "0.1.1-SNAPSHOT"] - [lein-ancient "0.6.2"]]} + [lein-ancient "0.6.7"]]} :dev-run {:clean-targets ^{:protect false} ["run/resources/public/compiled_dev"]} :prod-run {:clean-targets ^{:protect false} ["run/resources/public/compiled_prod"]} :dev-test {:clean-targets ^{:protect false} ["run/test/compiled"]}} @@ -65,7 +65,7 @@ :source-paths ["src"] :compiler {:output-to "run/resources/public/compiled_prod/demo.js" :output-dir "run/resources/public/compiled_prod/demo" - :closure-defines {:goog.DEBUG false} + :closure-defines {"goog.DEBUG" false} :optimizations :advanced :pretty-print false :pseudo-names false}} From c48a4ab58dbce6179a516c1f63e600d2623a637e Mon Sep 17 00:00:00 2001 From: Gregg8 Date: Mon, 18 Apr 2016 10:39:13 +1000 Subject: [PATCH 2/3] Fixed a bug in single-dropdown when you press home/end keys in filtered lists and the filtered list was empty & bumped figwheel --- project.clj | 7 ++++--- src/re_com/dropdown.cljs | 3 ++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/project.clj b/project.clj index b37838a5..5bebd8e4 100644 --- a/project.clj +++ b/project.clj @@ -29,11 +29,11 @@ :profiles {:dev {:dependencies [[clj-stacktrace "0.2.8"] [alandipert/storage-atom "1.2.4" ] - [figwheel "0.5.0-6"] + [figwheel "0.5.2"] [spellhouse/clairvoyant "0.0-48-gf5e59d3"] [secretary "1.2.3"]] :plugins [[lein-cljsbuild "1.1.2"] - [lein-figwheel "0.5.0-6"] + [lein-figwheel "0.5.2"] [lein-shell "0.5.0"] [com.cemerick/clojurescript.test "0.3.3"] [lein-s3-static-deploy "0.1.1-SNAPSHOT"] @@ -75,7 +75,8 @@ :output-dir "run/test/compiled/test" :source-map true :optimizations :none - :pretty-print true}}]} + :pretty-print true}}] + :test-commands {}} ;; figwheel 0.5.2 required this for some reason :figwheel {:css-dirs ["run/resources/public/assets/css"] :server-port ~fig-port diff --git a/src/re_com/dropdown.cljs b/src/re_com/dropdown.cljs index 064c033c..48129322 100644 --- a/src/re_com/dropdown.cljs +++ b/src/re_com/dropdown.cljs @@ -19,7 +19,8 @@ (= offset :end) (dec (count choices)) (nil? current-index) 0 :else (mod (+ current-index offset) (count choices)))] - (when new-index (id-fn (nth choices new-index))))) + (when (and new-index (pos? (count choices))) + (id-fn (nth choices new-index))))) (defn- choices-with-group-headings From 81d4dc82f7eca8668a0e8068299b9fd59e4f4c88 Mon Sep 17 00:00:00 2001 From: Gregg8 Date: Mon, 18 Apr 2016 11:32:53 +1000 Subject: [PATCH 3/3] Bump to 0.8.1 --- project.clj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/project.clj b/project.clj index 5bebd8e4..f8574d2a 100644 --- a/project.clj +++ b/project.clj @@ -4,7 +4,7 @@ ;; --------------------------------------------------------------------------------------- -(defproject re-com "0.9.0-SNAPSHOT" +(defproject re-com "0.8.1" :description "Reusable UI components for Reagent" :url "https://github.com/Day8/re-com.git" :license {:name "MIT"}