Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: header/banner image is randomly selected or shows multiple images #145

Closed
davidsneighbour opened this issue Jul 3, 2022 · 1 comment
Closed

bug: header/banner image is randomly selected or shows multiple images #145

davidsneighbour opened this issue Jul 3, 2022 · 1 comment
Assignees
@davidsneighbour
Labels
type:bug Bugfixes in codebase when something is not working.

Comments

@davidsneighbour
Copy link
Owner

Having a subsequent image is merely impossible because the banner-image.html will use it to show multiple banners. We need a system to make it simple and configurable:

  • if there is one image, that one is banner image
  • if there are more than one, something should indicate which one is the banner image
  • if there are more than one for a banner-slideshow, then something should indicate that too
@davidsneighbour davidsneighbour added type:bug Bugfixes in codebase when something is not working. state:unconfirmed This issue needs to be reproduced. labels Jul 3, 2022
@davidsneighbour davidsneighbour self-assigned this Jul 3, 2022
@davidsneighbour davidsneighbour mentioned this issue Jul 3, 2022
Closed
@davidsneighbour davidsneighbour added state:confirmed This issue is confirmed. and removed state:unconfirmed This issue needs to be reproduced. labels Jul 3, 2022
@davidsneighbour
Copy link
Owner Author

fixed somewhere along the lines, for further issues see davidsneighbour/hugo-modules#37 and davidsneighbour/hugo-modules#38

@davidsneighbour davidsneighbour removed the state:confirmed This issue is confirmed. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidsneighbour davidsneighbour

Labels
type:bug Bugfixes in codebase when something is not working.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidsneighbour