Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined notation / notation bug in Lecture 1 Concept Check, Topic 2, Question 1 #70

Open
davidrosenberg opened this issue Nov 26, 2018 · 3 comments

Comments

@davidrosenberg
Copy link
Owner

davidrosenberg commented Nov 26, 2018

What is N? If it's the minibatch size, it should be the subscript of m rather than n. @brett1479 right?

https://davidrosenberg.github.io/mlcourse/ConceptChecks/1-Lec-Check_sol.pdf

I think should be the same as: https://davidrosenberg.github.io/mlcourse/Archive/2017Fall/Lectures/02b.SGD.pdf#page=20
?

@brett1479
Copy link
Collaborator

I think the issue here is that it should say that the full training set is $(x_1,y_1),\ldots,(x_N,y_N)$, since otherwise the mini-batch and the training set have the same size (which is what it says now). We can swap them to make them agree with the lecture.

@brett1479
Copy link
Collaborator

@venik
Copy link

venik commented Nov 26, 2018

It would make sense to add 1 line with P(m_1 = i) under the sum, to make it a bit more clear from where \frac{1}{n} came from.
https://davidrosenberg.github.io/mlcourse/Archive/2017Fall/Lectures/02b.SGD.pdf#page=20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants