Autoselecting the appropriate inverter definition

[frsantos]

Hi @davidrapan

I finally got to test your integration and it works wonderfully. Thanks a lot!

I posted an idea on the other repository, but I think you are more open to new features. As you already have a discovery feature, it could be extended to make this extension even more user friendly.

It would be possible to automatically select one of the inverter definitions based on the serial number. From what I've read on many discussions, each serial inverter definition works only for a subset of serial numbers, so auto selecting an adequate definition would be just a matter of adding a list of supported serial number ranges to each definition file, and some code to match them against the configured one. If we add some info to the definition about which request we need to perform to get the SN, we can even make it completely automatic, as now even the IP/port can be auto-discovered too.

Also, inverters are usually rebranded with different names, but under the hood they are the same. So, another improvement could be to add the different inverter brands/models that are known to work with a definition file, and show them to the user when selecting a definition file. Something like "This definition file is known to work with the following inverters: ...". And again, sometimes the actual inverter name can be retrieved with another request: "This inverter references itself as ..."

So, the inverter file would have something like the following:

info:
  sns:
    accepted:
      - start: 127000000
        end:   127999999
      - start: 130000000
        end:   130999999 
    request:
      code: 0x04
      registers: [3228, 3229, 3230, 3231, 3232, 3233, 3234, 3235, 3236, 3237, 3238]
      rule: 5

  brands:
    accepted:
      - manufacturer: Manufacturer 1
        models:
          - Model X
          - Model Y
      - manufacturer: Other Manufacturer
        models: 
          - A Model
          - Another model
    model_request:
      code: 0x03
      registers: [3200, 3201, 3202, 3203, 3204, 3205, 3206, 3207]
      rule: 5

parameters:
  ....

[davidrapan]

Hi! First of all thank you!

That is a great idea! Even it's kinda hard to predict how good that gonna work I don't see a reason why we should not try it! Also even the serial of the device itself is in a lot of devices on similar registers...

It just gonna be a lot of data gathering at first before it's going to be somewhat useful (meaning in terms of serial matching).

And we will have to first set some validation checks in place to some crucial registers so they don't get all messed up when the matching fails as I for example when I accidentally load for deye_hybrid profile it fs up my "Total" sensors.

[oetiker]

and if #21 was there, the user base would probably grow and more people could contribute :) I certainly would.

[davidrapan]

Guess you proly already noticed but partial autodetection for inverters compatible w/ Deye is there already. ;)

[frsantos]

Hi @davidrapan

I was following the repo at the beginning, but lately there are too many notifications for me to follow. I saw some detection in some commit, but couldn't look in detail the implementation.

[davidrapan]

Sure, no pressure. I just wanted to inform. 😉

Implementation just stands for reading of register address 0 when set Auto as profile and then selecting file according to the value in that register. + Detecting number of MPPTs and Phases from register addresses 18 and 22.

As I said it's currently only for Deye compatible devices.