From aa1a6d94e4c54d5388e69152cd5ea519460db2c0 Mon Sep 17 00:00:00 2001 From: Alexander Spies Date: Mon, 16 Dec 2024 12:52:09 +0100 Subject: [PATCH] [8.x] ESQL: Disable LOOKUP JOIN physical optimizer test on release (#118754) * Disable test on release builds * Unmute --- muted-tests.yml | 3 --- .../xpack/esql/optimizer/PhysicalPlanOptimizerTests.java | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/muted-tests.yml b/muted-tests.yml index 8299efa7336f5..eca6805fc0544 100644 --- a/muted-tests.yml +++ b/muted-tests.yml @@ -461,9 +461,6 @@ tests: - class: org.elasticsearch.xpack.application.HuggingFaceServiceUpgradeIT method: testElser {upgradedNodes=1} issue: https://github.com/elastic/elasticsearch/issues/118127 -- class: org.elasticsearch.xpack.esql.optimizer.PhysicalPlanOptimizerTests - method: testVerifierOnMissingReferencesWithBinaryPlans {default} - issue: https://github.com/elastic/elasticsearch/issues/118707 - class: org.elasticsearch.xpack.application.CohereServiceUpgradeIT method: testCohereEmbeddings {upgradedNodes=1} issue: https://github.com/elastic/elasticsearch/issues/116974 diff --git a/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/PhysicalPlanOptimizerTests.java b/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/PhysicalPlanOptimizerTests.java index d43e41aed6a0e..70d5e10d34a73 100644 --- a/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/PhysicalPlanOptimizerTests.java +++ b/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/PhysicalPlanOptimizerTests.java @@ -2329,6 +2329,8 @@ public void testVerifierOnMissingReferences() { } public void testVerifierOnMissingReferencesWithBinaryPlans() throws Exception { + assumeTrue("Requires LOOKUP JOIN", EsqlCapabilities.Cap.JOIN_LOOKUP_V5.isEnabled()); + // Do not assert serialization: // This will have a LookupJoinExec, which is not serializable because it doesn't leave the coordinator. var plan = physicalPlan("""