Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the package still maintained? #21

Open
gpucce opened this issue Sep 8, 2021 · 3 comments
Open

Is the package still maintained? #21

gpucce opened this issue Sep 8, 2021 · 3 comments

Comments

@gpucce
Copy link
Contributor

gpucce commented Sep 8, 2021

Hi I would like to add a feature to the repo if it is still maintained. If it is can we talk about it?

@davidavdav
Copy link
Owner

Hello, yes, well, I fix bugs when they're there. I don't use the package often, myself, it needs better documentation for others to use, I suppose, but yes, I am in for a chat about it

@gpucce
Copy link
Contributor Author

gpucce commented Sep 8, 2021

Great! I'd like to add 2 things. An output like the one pROC gives in R and the Delong test for roc differences significance.

That said, I'm not sure I am able to do it and I am not familiar with some of the functions of this repo, meaning I don't really know what they represent xD

So if I try with a PR could you revise it and maybe before I make it discuss a little bit the implementation?

@davidavdav
Copy link
Owner

Sure, I know nothing about pROC and the Delong test. Maybe the data structure I use is not fit for it—I heavily reduce the data by collapsing uninterrupted datapoints of the same class, I do this in fractions rather than in counts, I believe. I suppose that original counts are going to play a role in significance tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants