Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: pixel_format and movie_dtype shouldn't be overwritten by camera type params #140

Open
jonahpearl opened this issue Nov 10, 2021 · 1 comment

Comments

@jonahpearl
Copy link

Current behavior: passing in, eg, --pixel-format uint8 doesn't do anything because in extract > util.py > detect_and_set_camera_parameters(), the args are overwritten by the camera settings because camera_type = "auto." To pass in custom params to pixel and movie formats, you also have to specify camera_type = either azure or kinect.

Expected behavior: a few options. I don't know the full extent of what camera_type is used for throughout the extraction, so take all this with a grain of salt.

  1. [not preferred but easiest] instead of failing silently, when you pass in custom args for pixel_format and movie_dtype without changing camera type from auto, it should raise an exception and specify that you need to specify camera type.
  2. [preferred] in between setting the default param dictionary and the line where it gets applied to the config (config_data.update(**default_parameters[detected])), update default_parameters to include any user specified stuff instead.
@jonahpearl
Copy link
Author

And corollary: Feature request: let user specify camera types other than kinect azure and realsense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant