Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to aws-sdk-s3 #108

Closed
Nugine opened this issue Mar 4, 2022 · 8 comments
Closed

Switch to aws-sdk-s3 #108

Nugine opened this issue Mar 4, 2022 · 8 comments

Comments

@Nugine
Copy link
Contributor

Nugine commented Mar 4, 2022

rusoto/rusoto#1651

https://docs.rs/aws-sdk-s3/latest/aws_sdk_s3/

Please Note: The SDK is currently released as a developer preview and is intended strictly for feedback purposes only. Do not use this SDK for production workloads.

@Nugine Nugine self-assigned this Mar 4, 2022
@Nugine
Copy link
Contributor Author

Nugine commented Mar 4, 2022

@pwang7 We have two choices now.

  • Stick to rusoto and wait for the offical sdk to be ready for production
  • Switch to aws-sdk-s3 even though it is a developer preview

@pwang7
Copy link
Collaborator

pwang7 commented Mar 4, 2022

@pwang7 We have two choices now.

  • Stick to rusoto and wait for the offical sdk to be ready for production
  • Switch to aws-sdk-s3 even though it is a developer preview

Which option do you prefer?

@Nugine
Copy link
Contributor Author

Nugine commented Mar 4, 2022

I prefer to switch now. s3-server only uses the type defintions from rusoso_s3. It won't take too much time if aws-sdk-s3's design is similiar to rusoto_s3. And the types may not have significant changes in the future.

Edit:
Maybe later. The error design needs changing to match the types defined in aws-sdk-s3.

Edit2:
Consider using smithy for type generation.

@lperlaki
Copy link
Contributor

lperlaki commented Mar 7, 2022

Hello,
I think there is also the option to generate the s3-server types and request parsing from the aws smithy models,
like s3d does. Though the smithy server codegen is a Work in Progress.

@Nugine
Copy link
Contributor Author

Nugine commented Mar 7, 2022

Hello, I think there is also the option to generate the s3-server types and request parsing from the aws smithy models, like s3d does. Though the smithy server codegen is a Work in Progress.

I haven't noticed it before. Thanks for informing.

@houqp
Copy link

houqp commented Dec 27, 2022

Before we switch to full smithy server codegen, it would be good to perform a quick benchmark to make sure the generated code is at least as efficient as the hand written implementation.

@Nugine
Copy link
Contributor Author

Nugine commented Jan 11, 2023

I'm investigating custom codegen implementation because smithy is not good enough yet for our requirements. I believe that s3d is facing the same problem.

s3-server was designed for hand written operation implementations. It works well for limited functionality but it is not the right way to reach the goal: Make it easy to build your own S3-compatible server.

Anyway, s3-server is an old and experimental project which is hard to mantain now. I encourage downstream projects to find an alternative if possible.

Related:

@Nugine
Copy link
Contributor Author

Nugine commented Jan 17, 2023

Investigation finished. The new design is published at https://github.com/Nugine/s3s.

Announcement

  • s3-server project is now unmaintained, like rusoto.
  • s3s project is the successor of s3-server. s3s inherits all functionality that s3-server has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants