Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standard task runes #86

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Standard task runes #86

merged 3 commits into from
Aug 21, 2024

Conversation

eccles
Copy link
Member

@eccles eccles commented Aug 20, 2024 •
edited
Loading

Also ensure that go.mod is up to date

Test results:

 task test:unit PASS
 task azurite:preflight && task test:azurite PASS

Linked to avid:

smoke: RESULTS: Tests 131 , Errors 0 , Failures 0 , Time 97.299
core: RESULTS: Tests 556 , Errors 0 , Failures 0 , Time 293.290

AB#9472

@eccles
Standard task runes
00479c4 
Also ensure that go.mod is up to date

AB#9472
j-hartley
j-hartley previously requested changes Aug 20, 2024
View reviewed changes
taskfiles/Taskfile_codeqa.yml Show resolved Hide resolved
taskfiles/Taskfile_codeqa.yml Show resolved Hide resolved
taskfiles/Taskfile_codeqa.yml Show resolved Hide resolved
@eccles eccles requested a review from j-hartley August 20, 2024 09:20
robinbryce
robinbryce requested changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@robinbryce robinbryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to resolve the version of grpc-gatway this way

taskfiles/Taskfile_codeqa.yml Outdated Show resolved Hide resolved
@eccles eccles requested a review from robinbryce August 21, 2024 08:38
@eccles eccles force-pushed the dev/paul/9472-common-task-runes branch from d963d30 to aa0286b Compare August 21, 2024 08:42
robinbryce
robinbryce approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@robinbryce robinbryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eccles eccles requested a review from robinbryce August 21, 2024 09:51
@eccles eccles merged commit 9de169e into main Aug 21, 2024
2 checks passed
@eccles eccles deleted the dev/paul/9472-common-task-runes branch August 21, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waarg waarg Awaiting requested review from waarg

@landintrees landintrees Awaiting requested review from landintrees

@j-hartley j-hartley Awaiting requested review from j-hartley

@robinbryce robinbryce Awaiting requested review from robinbryce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eccles @robinbryce @j-hartley