Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky blobs caps systemtest #77

Merged
merged 7 commits into from
Aug 14, 2024
Merged

Flaky blobs caps systemtest #77

merged 7 commits into from
Aug 14, 2024

Conversation

eccles
Copy link
Member

@eccles eccles commented Jul 18, 2024 •
edited
Loading

Reading the logs emitted by Debug log statements shows:

 2024-08-08T12:50:50.028Z    DEBUG    azblob/list.go:19    Count
 2024-08-08T12:50:50.032Z    DEBUG    azblob/list.go:36    Count 2

indicating that the code works and incurs 40ms delay only.

All systemtests pass - unfortunately the flaky blobs caps tests still fail

(the debug log statements have been removed)

AB#5311

@eccles eccles force-pushed the dev/paul/flaky-blobs-systemtest branch from 02a1d07 to c24287f Compare July 26, 2024 12:52
@eccles eccles force-pushed the dev/paul/flaky-blobs-systemtest branch from c24287f to b62c45a Compare August 7, 2024 08:50
robinbryce
robinbryce reviewed Aug 7, 2024
View reviewed changes
azblob/list.go Outdated Show resolved Hide resolved
robinbryce
robinbryce reviewed Aug 7, 2024
View reviewed changes
azblob/list.go Outdated Show resolved Hide resolved
@eccles eccles force-pushed the dev/paul/flaky-blobs-systemtest branch 4 times, most recently from db0b12a to 210909f Compare August 8, 2024 13:24
@eccles eccles marked this pull request as ready for review August 8, 2024 13:25
@eccles eccles requested review from robinbryce and henry739 August 8, 2024 13:27
@eccles eccles force-pushed the dev/paul/flaky-blobs-systemtest branch from 210909f to af177d9 Compare August 14, 2024 09:51
@eccles eccles force-pushed the dev/paul/flaky-blobs-systemtest branch from af177d9 to 139dc55 Compare August 14, 2024 09:54
@eccles eccles requested review from robinbryce and j-hartley August 14, 2024 12:37
robinbryce
robinbryce reviewed Aug 14, 2024
View reviewed changes
azblob/list.go Outdated Show resolved Hide resolved
robinbryce
robinbryce requested changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@robinbryce robinbryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't understand your changes to FilteredList

@eccles eccles requested a review from robinbryce August 14, 2024 13:11
robinbryce
robinbryce reviewed Aug 14, 2024
View reviewed changes
azblob/list.go Outdated Show resolved Hide resolved
robinbryce
robinbryce requested changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@robinbryce robinbryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the opts in count grows redundantly and infinitely (at least to the number of pages)

@eccles eccles requested a review from robinbryce August 14, 2024 13:50
robinbryce
robinbryce previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@robinbryce robinbryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eccles eccles requested a review from robinbryce August 14, 2024 14:18
@eccles eccles enabled auto-merge (squash) August 14, 2024 14:19
robinbryce
robinbryce approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@robinbryce robinbryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eccles eccles merged commit f281e36 into main Aug 14, 2024
2 checks passed
@eccles eccles deleted the dev/paul/flaky-blobs-systemtest branch August 14, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinbryce robinbryce robinbryce approved these changes

@Serhiy1 Serhiy1 Awaiting requested review from Serhiy1

@honourfish honourfish Awaiting requested review from honourfish

@rcoxhill-01 rcoxhill-01 Awaiting requested review from rcoxhill-01

@henry739 henry739 Awaiting requested review from henry739

@j-hartley j-hartley Awaiting requested review from j-hartley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eccles @robinbryce @j-hartley