Handle port correctly #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eccles
force-pushed
the
dev/paul/8760-port-usage
branch
3 times, most recently
from
f101ea4 to
6ea6f74
Compare
eccles
force-pushed
the
dev/paul/8760-port-usage
branch
from
6ea6f74 to
66881f7
Compare
honourfish
reviewed
Jul 18, 2024
robinbryce
reviewed
Jul 18, 2024
eccles
force-pushed
the
dev/paul/8760-port-usage
branch
5 times, most recently
from
984592c to
f012aa0
Compare
Allow the user to specify the name of the port env variable. Some services do not use the PORT variable when the do not have a grpcserver. Add local logger to tracing. Remove company name from tracing/StartSpanFromContext AB#8760
eccles
force-pushed
the
dev/paul/8760-port-usage
branch
from
f012aa0 to
9f97431
Compare
j-hartley
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to specify the name of the port env variable. Some services do not use the PORT variable when the do not have a grpcserver.
Add local logger to tracing
AB#8760