Use context.WithoutCancel in azbus #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinbryce
requested changes
Sep 4, 2023
added 3 commits
September 5, 2023 16:17
The handcrafted contextWithoutCancel is replaced with correct standard context.WithoutCancel from Go 1.21. If processing a message takes longer than the message deadline a WARNING is emitted with suggested remedial action. Type aliases in aliases.go have been moved closer to their point of usage and aliases.go deleted. Internal logger is indexed with the name of the sender/receiver. Mock generation Taskfile is added. AB#8276
eccles
force-pushed
the
dev/paul/8276-report-elapsed-times
branch
from
3b575ba to
ce7bfbe
Compare
robinbryce
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handcrafted contextWithoutCancel is replaced with correct standard context.WithoutCancel from Go 1.21.
If processing a message takes longer than the message deadline a WARNING is emitted with suggested remedial action.
Type aliases in aliases.go have been moved closer to their point of usage and aliases.go deleted.
Internal logger is indexed with the name of the sender/receiver.
Mock generation Taskfile is added.
AB#8276