Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics #27

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Add metrics #27

merged 5 commits into from
Dec 14, 2023

Conversation

eccles
Copy link
Member

@eccles eccles commented Oct 26, 2023 •
edited
Loading

Metrics package

AB#8684

@eccles eccles force-pushed the dev/paul/8684-metrics branch 3 times, most recently from 8a4b9a2 to 2bfa8cd Compare October 26, 2023 15:37
@eccles eccles marked this pull request as draft October 30, 2023 11:06
@eccles eccles force-pushed the dev/paul/8684-metrics branch 2 times, most recently from bc692f9 to 64fca31 Compare October 31, 2023 10:31
@eccles eccles force-pushed the dev/paul/8684-metrics branch from 64fca31 to 105c874 Compare November 9, 2023 14:57
@eccles eccles force-pushed the dev/paul/8684-metrics branch 2 times, most recently from babc80f to d5774b0 Compare December 12, 2023 16:22
Add metrics
37e2527 
Metrics package

AB#8684
@eccles eccles force-pushed the dev/paul/8684-metrics branch from d5774b0 to 37e2527 Compare December 12, 2023 16:40
@eccles eccles marked this pull request as ready for review December 13, 2023 08:22
@eccles eccles requested a review from robinbryce December 13, 2023 08:22
honourfish
honourfish reviewed Dec 13, 2023
View reviewed changes
metrics/handler.go Outdated Show resolved Hide resolved
honourfish
honourfish reviewed Dec 13, 2023
View reviewed changes
metrics/observers.go Outdated Show resolved Hide resolved
@eccles eccles requested a review from honourfish December 14, 2023 11:12
@eccles eccles enabled auto-merge (squash) December 14, 2023 11:37
@eccles eccles merged commit 4b22891 into main Dec 14, 2023
1 check passed
@eccles eccles deleted the dev/paul/8684-metrics branch December 14, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honourfish honourfish honourfish approved these changes

@waarg waarg Awaiting requested review from waarg

@j-hartley j-hartley Awaiting requested review from j-hartley

@landintrees landintrees Awaiting requested review from landintrees

@robinbryce robinbryce Awaiting requested review from robinbryce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eccles @honourfish