Update CWT_Claims to 15 #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: steve lasker <[email protected]>
|
Pending back-end change. |
honourfish
previously approved these changes
Nov 15, 2024
Signed-off-by: Steve Lasker <[email protected]>
Signed-off-by: steve lasker <[email protected]>
Signed-off-by: steve lasker <[email protected]>
Signed-off-by: steve lasker <[email protected]>
Signed-off-by: steve lasker <[email protected]>
|
@robinbryce, can you PTAL |
JAG-UK
reviewed
Nov 21, 2024
|
|
||
| # subject header label comes from version 2 of the scitt architecture document | ||
| # # subject header label comes from version 2 of the scitt architecture document |
There was a problem hiding this comment.
Suggested change
| # # subject header label comes from version 2 of the scitt architecture document | |
| # subject header label comes from version 2 of the scitt architecture document |
| # CWT header label is defined by | ||
| # https://datatracker.ietf.org/doc/html/draft-ietf-cose-cwt-claims-in-headers-10#section-2 | ||
| # And referenced by https://www.ietf.org/archive/id/draft-ietf-scitt-architecture-10.html#name-signed-statements | ||
| HEADER_LABEL_CWT = 15 | ||
|
|
||
| # CWT header label previously came from version 4 of the scitt architecture document | ||
| # https://www.ietf.org/archive/id/draft-ietf-scitt-architecture-04.html#name-issuer-identity | ||
| HEADER_LABEL_CWT_SCITT_DRAFT_04 = 13 |
There was a problem hiding this comment.
Why have you left this here if it's not used anymore?
robinbryce
requested changes
Nov 21, 2024
|
abandoned for #38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As CTW_CLAIMS was finalized, the value changed from 13 to 15
https://www.iana.org/assignments/cose/cose.xhtml#header-parameters
Fixes #25