Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the workflow thing work for PR's ? #31

Merged
merged 3 commits into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
name: Build and test

on:
push:

workflow_call:
jobs:
build:
strategy:
Expand Down
34 changes: 12 additions & 22 deletions .github/workflows/merge-requires.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,29 +5,19 @@
# appropriate to satisfy that check.
name: Merge Requires
on:
workflow_run:
workflows:
- Build and test
- Package and Publish
types:
- completed
push:

jobs:
ci:
secrets: inherit
uses: ./github/workflows/ci.yml
release:
secrets: inherit
uses: ./github/workflows/package.yml

merge-checks-ok:
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' }}
steps:
- run: |
echo 'The merge check passed'
echo ${{ github.event.workflow_run.name }}
echo ${{ github.event.workflow_run.url }}
needs: [ci]

merge-checks-failed:
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'failure' }}
steps:
- run: |
echo 'The merge check failed'
echo ${{ github.event.workflow_run.name }}
echo ${{ github.event.workflow_run.url }}
exit 1
release-checks-ok:
if: ${{ github.event_name == 'release' }}
needs: [ci, release]
3 changes: 1 addition & 2 deletions .github/workflows/package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
name: Package and Publish

on:
pull_request:
release:
workflow_call:

jobs:
build:
Expand Down
3 changes: 0 additions & 3 deletions unittests/test_create_hashed_signed_statement.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,6 @@ def test_sign_and_verify_statement(self):
tests we can also verifiy that signed statement.
"""

# XXX: TODO: Testing CI/CD infra: should still fail the Merge Requires check
assert False is True

# create the signed statement
signing_key = SigningKey.generate(curve=NIST256p)

Expand Down