Dev/robin/9530 end to end scitt #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
October 31, 2024 10:07
The local workflow does not agree with the CI for mysterious reasons
robinbryce
commented
Oct 31, 2024
Signed-off-by: steve lasker <[email protected]>
Signed-off-by: steve lasker <[email protected]>
Signed-off-by: steve lasker <[email protected]>
|
Updated to:
I got all the tests running locally
It is not passing CI, 😢 and I could use a wee bit of help |
SteveLasker
previously approved these changes
Nov 13, 2024
There was a problem hiding this comment.
LGTM,
We need to resolve #25, however that will be a separate coordinated backend PR.
Signed-off-by: steve lasker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update scitt samples to show end to end scitt statement creation, registration and verification
Implements a simple common configuration context pattern for interacting with the DataTrails SCITT and proprietary apis and consistent use of logging.
The pattern accomodates CI config via environment and imperative config for command line use.
Also, refactor the scripts and packages so they can be consumed by scitt-actions and the like.