Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detached payload signed statement creation script #14

Merged
merged 18 commits into from
Jul 2, 2024
Merged

Add detached payload signed statement creation script #14

merged 18 commits into from
Jul 2, 2024

Conversation

honourfish
Copy link
Collaborator

@honourfish honourfish commented Jun 20, 2024 •
edited
Loading

Overview

  • Hashes the given statement and uses the hash as the payload on the signed scitt statement.

re: AB#9458

SteveLasker
SteveLasker reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback, building on the sketch in: Updates for Arch -07 and SCRAPI -03 #8

scitt/create_detatched_signed_statement.py Outdated Show resolved Hide resolved
scitt/create_detatched_signed_statement.py Outdated Show resolved Hide resolved
scitt/create_detatched_signed_statement.py Outdated Show resolved Hide resolved
scitt/create_detatched_signed_statement.py Outdated Show resolved Hide resolved
scitt/create_detatched_signed_statement.py Outdated Show resolved Hide resolved
scitt/create_detatched_signed_statement.py Outdated Show resolved Hide resolved
scitt/create_detatched_signed_statement.py Outdated Show resolved Hide resolved
scitt/create_detatched_signed_statement.py Outdated Show resolved Hide resolved
scitt/create_detatched_signed_statement.py Outdated Show resolved Hide resolved
scitt/create_detatched_signed_statement.py Outdated Show resolved Hide resolved
honourfish and others added 14 commits June 21, 2024 07:08
@honourfish @SteveLasker
Update scitt/create_detatched_signed_statement.py
4541221 
Co-authored-by: Steve Lasker <[email protected]>
Signed-off-by: Joe Gough <[email protected]>
@honourfish @SteveLasker
Update scitt/create_detatched_signed_statement.py
84d0411 
Co-authored-by: Steve Lasker <[email protected]>
Signed-off-by: Joe Gough <[email protected]>
@honourfish @SteveLasker
Update scitt/create_detatched_signed_statement.py
1cf104f 
Co-authored-by: Steve Lasker <[email protected]>
Signed-off-by: Joe Gough <[email protected]>
@honourfish @SteveLasker
Update scitt/create_detatched_signed_statement.py
db696c0 
Co-authored-by: Steve Lasker <[email protected]>
Signed-off-by: Joe Gough <[email protected]>
@honourfish @SteveLasker
Update scitt/create_detatched_signed_statement.py
adb9390 
Co-authored-by: Steve Lasker <[email protected]>
Signed-off-by: Joe Gough <[email protected]>
fixup
9ba16ee
fixup linting
7c830c6
fixup linting
ee3fac2
fixup
8736634
fixup linting
4e7fa49
fixup linting
c85d001
fixup formatting
1b84735
fixup no feed
7d81cac
fixup remove feed from unittest
78973fc
henry739
henry739 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@henry739 henry739 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@honourfish honourfish merged commit 0ff950e into main Jul 2, 2024
10 checks passed
@honourfish honourfish deleted the dev/jgough/9458-detached-payload-statement branch July 2, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveLasker SteveLasker SteveLasker left review comments

@henry739 henry739 henry739 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@honourfish @SteveLasker @henry739