Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFAL/Shibboleth login - new error page when the email already exist? #778

Closed
milanmajchrak opened this issue Oct 3, 2024 · 2 comments
Closed
Assignees

Comments

@milanmajchrak
Copy link
Collaborator

Not a specific error, because it indicates to the user that someone with this email is signed into DSpace. Potential security issue.

Just show an error page indicating that login was unsuccessful.

@milanmajchrak milanmajchrak self-assigned this Oct 3, 2024
@milanmajchrak
Copy link
Collaborator Author

During this issue some Vanilla tests have started failing.

I asked a question in the Slack:

Hi all, some unit tests in the GitHub action have suddenly started failing. This has happened in the past as well (see: https://dspace-org.slack.com/archives/C3N0VHT6K/p1725885382827249), but now different tests are failing.
Error log:
Error:  Failures: 
Error:  org.dspace.external.CachingOrcidRestConnectorTest.getLabel(org.dspace.external.CachingOrcidRestConnectorTest)
Error:    Run 1: CachingOrcidRestConnectorTest.getLabel:69 expected:<Connor, John> but was:<null>
Error:    Run 2: CachingOrcidRestConnectorTest.getLabel:69 expected:<Connor, John> but was:<null>
Error:    Run 3: CachingOrcidRestConnectorTest.getLabel:69 expected:<Connor, John> but was:<null>
[INFO] 
Error:  org.dspace.external.CachingOrcidRestConnectorTest.search(org.dspace.external.CachingOrcidRestConnectorTest)
Error:    Run 1: CachingOrcidRestConnectorTest.search:80
Error:    Run 2: CachingOrcidRestConnectorTest.search:80
Error:    Run 3: CachingOrcidRestConnectorTest.search:80
[INFO] 
Error:  org.dspace.external.CachingOrcidRestConnectorTest.testCachable(org.dspace.external.CachingOrcidRestConnectorTest)
Error:    Run 1: CachingOrcidRestConnectorTest.testCachable:123 expected:<Connor, John> but was:<null>
Error:    Run 2: CachingOrcidRestConnectorTest.testCachable:123 expected:<Connor, John> but was:<null>
Error:    Run 3: CachingOrcidRestConnectorTest.testCachable:123 expected:<Connor, John> but was:<null>
[INFO] 
Error:  org.dspace.external.CachingOrcidRestConnectorTest.testCacheableWithError(org.dspace.external.CachingOrcidRestConnectorTest)
Error:    Run 1: CachingOrcidRestConnectorTest.testCacheableWithError:153 expected:<Connor, John> but was:<null>
Error:    Run 2: CachingOrcidRestConnectorTest.testCacheableWithError:153 expected:<Connor, John> but was:<null>
Error:    Run 3: CachingOrcidRestConnectorTest.testCacheableWithError:153 expected:<Connor, John> but was:<null>
[INFO] 
[INFO] 
Error:  Tests run: 1199, Failures: 4, Errors: 0, Skipped: 10
I noticed this issue yesterday. It is also happening in more branches, even in those where all checks had previously passed.
Has anyone else noticed this and, hopefully, already found a solution?

Thank you!

@milanmajchrak
Copy link
Collaborator Author

e2732a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant