New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitstream import null control #776

Closed

Paurikova2 opened this issue Oct 3, 2024 · 1 comment · Fixed by #774

Collaborator

Paurikova2 commented Oct 3, 2024

Because https://github.com/orgs/dataquest-dev/projects/12/views/32?pane=issue&itemId=81156787
Problem: During Ondrej's bitstream import, two bitstreams were not imported. The byte_size of this bitstream is null. We tried inserting a null value into a long type (

DSpace/dspace-server-webapp/src/main/java/org/dspace/app/rest/ClarinBitstreamImportController.java

Line 140 in 140f0b7

bitstream.setSizeBytes(bitstreamRest.getSizeBytes());

)
Task: Check that the entered value is not null.
Solution: Add not null check. https://github.com/dataquest-dev/DSpace/blob/140f0b72b2b79ee236e2c2b29ad1e981080a9e9e/dspace-server-webapp/src/main/java/org/dspace/app/rest/ClarinBitstreamImportController.java#L103 add SQL exception to error message.

Paurikova2 linked a pull request

that will close this issue

test for bitstream with null value for sizebytes #774

Merged

Collaborator Author

Paurikova2 commented Oct 3, 2024

merge with https://github.com/orgs/dataquest-dev/projects/12/views/28?filterQuery=&pane=issue&itemId=81994882

Paurikova2 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment