Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images are tranferred either an image or a background #21

Open
sbalci opened this issue Nov 3, 2019 · 4 comments
Open

images are tranferred either an image or a background #21

sbalci opened this issue Nov 3, 2019 · 4 comments

Comments

@sbalci
Copy link

sbalci commented Nov 3, 2019

Thank you very much for this package. Very useful. I will use it to convert my lecture notes into html slides.

My presentations include many graphs and pictures. Some images are transferred as expected:

![](assets/img/image48.png)

but others are transferred as background:

class: inverse
background-image: url('assets/img/image31.jpg')
background-size: cover

I could not understand the logic behind this difference. Is it because when there is one image per slide, or if there is accompanying note or text per slide? Being png or jpeg also does not matter, some are background, some are as picture.

Thank you again for the package.

@datalorax
Copy link
Owner

Hi,

The logic deals with the number of images on a slide. If there are three or more, then it gets split into separate slides. I made that decision because often when there were multiple pictures in a slide they would end up running of the slide and you couldn't see them at all. I'm open to alternative options, but you can also edit by hand fairly easily after the initial rendering. The conversion is not perfect and is unlikely to ever be fully perfect, but it should help you get most of the way there.

@sbalci
Copy link
Author

sbalci commented Nov 4, 2019

Hello,
Thank you very much for the response.
When there are two pictures you aligned them right and left as far as I can see.
I do not know other fields but as a pathologist I would not prefer any picture to be background. I would prefer ![](assets/img/image48.png) format for every picture.
Is there an option or argument for that?

Thank you again for the package.
Best wishes

@datalorax
Copy link
Owner

There is not, but again, the issue is not dependent on the field, it is that those pictures end up stacking on top of each other and running of the slide so you they don't show up at all (outside of the first picture and maybe the second, or the second may be cut off).

I don't think it would be too terribly difficult to create an argument for the pictures all come in as you suggest though. You'd probably just need to include slide separators in there when they run off.

Unfortunately, as you can probably tell from the commit history, this hasn't been under active development for a while. If I am able to get back to it anytime soon, I can try to embed this change.

@sbalci
Copy link
Author

sbalci commented Nov 4, 2019

Thank you again.
I really liked this package.
Best wishes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants