Fix general regression issues and implement other requested changes #105
Conversation
zitrosolrac
changed the title
There was a problem hiding this comment.
@zitrosolrac Awesome contributions! Really nice to see you getting the hang of this, Carlos. Excellent work. 💪
Points raised here are quite minor so we should be ready for a merge soon. The main one is regarding a small bug in unsetting the Brain Regions filter.
We can likely merge it in our next tagup and start planning for the next deploy cycle.
| @@ -375,6 +391,10 @@ export class SessionListComponent implements OnInit, OnDestroy { | |||
| continue | |||
| } | |||
| } | |||
| if(key == 'brain_regions' && value !== null){ | |||
There was a problem hiding this comment.
There appears to be a small bug related to 'unsetting' the brain filter after use. For instance, when I apply HPF as a filter, it appropriately restricts to 2 records but when I simply empty the text box, it shows 0 results.
There was a problem hiding this comment.
This been address in the latest commit!
ibl-frontend/frontend-content/src/app/session-list/session-list.component.ts
Outdated
Show resolved
Hide resolved
ibl-frontend/frontend-content/src/app/session-list/session/session.component.css
Show resolved
Hide resolved
There was a problem hiding this comment.
@zitrosolrac This looks great man! 😎
Just need to remove some unnecessary comments and we should be ready to merge. 👍
backend/iblapi.py
Outdated
| @@ -250,6 +250,11 @@ def handle_q(subpath, args, proj, fetch_args=None, **kwargs): | |||
| training_status='training_status', good_enough_for_brainwide_map='good_enough_for_brainwide_map', | |||
| keep_all_rows=True | |||
| ) | |||
| subj = subject.Subject().aggr( | |||
| subject.Death().proj('death_date') * dj.U('death_date'), | |||
| # death_date='IF(death_date>0, 1, 0)', | |||
There was a problem hiding this comment.
| # death_date='IF(death_date>0, 1, 0)', |
|
|
||
| <!-- <mat-form-field> | ||
| <label>Alive/Deceased</label> | ||
| <input matInput type="text" name="death_date" formControlName="death_date" | ||
| [matAutocomplete]="autoCompRU" (focus)="stepBackMenu($event)"> | ||
| <mat-autocomplete #autoCompRU="matAutocomplete"> | ||
| <mat-option *ngFor="let death_date of dropDownMenuOptions.filteredResponsibleUserOptions | async" [value]="death_date" | ||
| (click)="updateMenu()">{{ death_date }}</mat-option> | ||
| </mat-autocomplete> | ||
| </mat-form-field> --> | ||
|
|
There was a problem hiding this comment.
| <!-- <mat-form-field> | |
| <label>Alive/Deceased</label> | |
| <input matInput type="text" name="death_date" formControlName="death_date" | |
| [matAutocomplete]="autoCompRU" (focus)="stepBackMenu($event)"> | |
| <mat-autocomplete #autoCompRU="matAutocomplete"> | |
| <mat-option *ngFor="let death_date of dropDownMenuOptions.filteredResponsibleUserOptions | async" [value]="death_date" | |
| (click)="updateMenu()">{{ death_date }}</mat-option> | |
| </mat-autocomplete> | |
| </mat-form-field> --> |
Fix #77
Before
After
Fix #98
Before
After
Fix #97
Fix #81
Fix #82
Fix #96